Skip to content

Commit 97eefe2

Browse files
committed
fix: gate record-connector-registry on docker job success
The job condition checked binaries and windows but not docker. When goreleaser-docker failed, the manifest and S3 upload still ran with incomplete release artifacts (missing container images). Add docker result check: must be success or skipped (skipped when docker=false && lambda=false).
1 parent 8971c8d commit 97eefe2

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/release.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -909,8 +909,9 @@ jobs:
909909
910910
record-connector-registry:
911911
# require binaries to succeed; windows and docker may be skipped (msi=false, docker=false && lambda=false)
912+
# docker must succeed if it ran — a failed docker build means incomplete release artifacts
912913
# see: https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution
913-
if: ${{ !cancelled() && needs.goreleaser-binaries.result == 'success' && (needs.goreleaser-windows.result == 'success' || needs.goreleaser-windows.result == 'skipped') }}
914+
if: ${{ !cancelled() && needs.goreleaser-binaries.result == 'success' && (needs.goreleaser-windows.result == 'success' || needs.goreleaser-windows.result == 'skipped') && (needs.goreleaser-docker.result == 'success' || needs.goreleaser-docker.result == 'skipped') }}
914915
needs: [determine-workflows-ref, goreleaser-binaries, goreleaser-windows, goreleaser-docker]
915916
permissions:
916917
id-token: write

0 commit comments

Comments
 (0)