Skip to content

concoredocker.py has no test coverage #210

@avinxshKD

Description

@avinxshKD

The test_concore.py only covers concore.py but there's nothing for concoredocker.py.

Looking at the code, concoredocker.py has its own implementations of read(), write(), initval(), unchanged() etc that are different from concore.py - uses absolute paths /in and /out instead of relative, slightly different error handling, etc.

These differences could easily break in Docker containers without anyone noticing since there's no tests running against the docker variant.

so should probably add at least basic tests for:

  • safe_literal_eval()

  • read() and write() with mocked file paths

  • initval() parsing

  • unchanged() state tracking

Would also catch the kind of drift that happens when someone updates concore.py but forgets concoredocker.py.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions