runMemoryReflection missing isInvalidAgentIdFormat guard (inconsistent with other hook sites)

[jlin53882]

Issue: runMemoryReflection missing isInvalidAgentIdFormat guard

Problem

The runMemoryReflection command hook in index.ts lacks a isInvalidAgentIdFormat() guard before calling isAgentOrSessionExcluded(). This creates an inconsistency with the other 5 hook sites that all have this guard.

Affected location: index.ts:3507 (approximate line, within runMemoryReflection)

Current code:

const sourceAgentId = parseAgentIdFromSessionKey(sessionKey) || "main";
// ⚠️  Missing isInvalidAgentIdFormat guard here
const excludePatterns = config.memoryReflection?.excludeAgents;
if (excludePatterns && isAgentOrSessionExcluded(sourceAgentId, sessionKey, excludePatterns)) {
  api.logger.debug?.(`memory-reflection: command hook skipped (excluded agent=...)`);
  return;
}

Why this matters

• All other 5 hook sites (before_prompt_build × 4, before_reset × 1) have isInvalidAgentIdFormat() as a前置 guard
• runMemoryReflection is the only site that jumps directly to isAgentOrSessionExcluded() without the format check
• Currently protected by || "main" fallback, but this is fragile defense-in-depth
• A future refactor removing the fallback would expose a potential issue

Proposed fix

Add isInvalidAgentIdFormat guard before isAgentOrSessionExcluded:

const sourceAgentId = parseAgentIdFromSessionKey(sessionKey) || "main";
// ✅  Add format validation guard (consistent with other hook sites)
if (isInvalidAgentIdFormat(sourceAgentId, config.declaredAgents)) {
  api.logger.debug?.(
    `memory-reflection: command hook skipped — invalid agentId '${sourceAgentId}'`,
  );
  return;
}
const excludePatterns = config.memoryReflection?.excludeAgents;
if (excludePatterns && isAgentOrSessionExcluded(sourceAgentId, sessionKey, excludePatterns)) {
  api.logger.debug?.(
    `memory-reflection: command hook skipped (excluded agent=${sourceAgentId}, sessionKey=${sessionKey ?? "(none)"})`,
  );
  return;
}

Context

• Related to PR fix: complete Issue #492 protection -- per-agent exclusion + internal session guards #516 (Issue memoryReflection hook in before_prompt_build starves user session (beta.10) #492 per-agent exclusion)
• All 6 hook sites should have consistent guards

Labels

bug, good first issue

[jlin53882]

Fix submitted

PR #687 opened from fix/issue-686-missing-guard branch.

This PR adds the missing isInvalidAgentIdFormat guard to runMemoryReflection, making it consistent with all other hook sites.

Note: This PR builds on #516 (per-agent exclusion). It should be reviewed after #516 is merged.

Links

• PR: fix: add isInvalidAgentIdFormat guard to runMemoryReflection (Issue #686) #687
• Parent PR: fix: complete Issue #492 protection -- per-agent exclusion + internal session guards #516