From 10f56b0a812161e30db45e33f6ffe960b25d90de Mon Sep 17 00:00:00 2001 From: zachery with an e <45150570+zweatshirt@users.noreply.github.com> Date: Wed, 20 May 2026 14:21:03 -0500 Subject: [PATCH 1/2] Update formula in salary breakdown to specify geographic multiplier --- .../HrTools/PdsGoalCalculator/SupportItem/salaryBreakdown.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/HrTools/PdsGoalCalculator/SupportItem/salaryBreakdown.tsx b/src/components/HrTools/PdsGoalCalculator/SupportItem/salaryBreakdown.tsx index 80c3330382..84e0253af1 100644 --- a/src/components/HrTools/PdsGoalCalculator/SupportItem/salaryBreakdown.tsx +++ b/src/components/HrTools/PdsGoalCalculator/SupportItem/salaryBreakdown.tsx @@ -76,7 +76,7 @@ export const buildSalaryBreakdownRows = ( { id: 'gross-monthly-pay', category: t('Gross Monthly Pay'), - formula: t('Monthly Base × {{rate}}', { + formula: t('Monthly Base × Geographic Multiplier ({{rate}})', { rate: percentageFormat(1 + geographicMultiplier, locale), }), amount: grossMonthlyPay, From 0a61001893deec65539b195ade9ecf3396614aba Mon Sep 17 00:00:00 2001 From: zachery with an e <45150570+zweatshirt@users.noreply.github.com> Date: Wed, 20 May 2026 14:39:48 -0500 Subject: [PATCH 2/2] Try to improve test timeout issue --- .../StaffExpenseReport.test.tsx | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/components/Reports/StaffExpenseReport/StaffExpenseReport.test.tsx b/src/components/Reports/StaffExpenseReport/StaffExpenseReport.test.tsx index e449aebb04..d5a03771bd 100644 --- a/src/components/Reports/StaffExpenseReport/StaffExpenseReport.test.tsx +++ b/src/components/Reports/StaffExpenseReport/StaffExpenseReport.test.tsx @@ -277,29 +277,26 @@ describe('StaffExpenseReport', () => { }); it('shows month title and navigation when only category filters are applied', async () => { - const { getByRole, findByRole, findByLabelText, queryByText } = render( + const { getByRole, findByLabelText, findByRole } = render( , ); userEvent.click(getByRole('button', { name: 'Filter Settings' })); userEvent.click(await findByLabelText('Assessment')); - userEvent.click(await findByRole('button', { name: 'Apply Filters' })); + await waitFor(() => + expect(getByRole('button', { name: 'Apply Filters' })).not.toBeDisabled(), + ); + userEvent.click(getByRole('button', { name: 'Apply Filters' })); expect( await findByRole('heading', { name: 'January 2020', level: 6 }), ).toBeInTheDocument(); - expect( - await findByRole('button', { name: 'Previous Month' }), - ).toBeInTheDocument(); - expect( - await findByRole('button', { name: 'Next Month' }), - ).toBeInTheDocument(); - expect(queryByText('Clear Filters')).not.toBeInTheDocument(); - }); + expect(getByRole('button', { name: 'Previous Month' })).toBeInTheDocument(); + expect(getByRole('button', { name: 'Next Month' })).toBeInTheDocument(); + }, 10000); it('shows filter date range title and hides month navigation when date filters are applied', async () => { - const originalNow = Settings.now; Settings.now = () => new Date(2020, 0, 20).valueOf(); const { getByRole, findByRole, getByLabelText, queryByRole } = render( @@ -330,7 +327,5 @@ describe('StaffExpenseReport', () => { expect( queryByRole('button', { name: 'Next Month' }), ).not.toBeInTheDocument(); - - Settings.now = originalNow; }, 10000); });