Fix: quickfort UI freeze on large blueprints and strip undocumented ghost-features

Author: sizzlins

gui/quickfort.lua

@@ -129,7 +129,7 @@ function BlueprintDialog:init()
                 },
                 widgets.HotkeyLabel{
                     frame={b=0, l=15},
-                    key='SELECT_ALL', -- TODO: change to SEC_SELECT once 51.01 is stable
+                    key='SEC_SELECT',
                     label='Delete selected blueprint',
                     on_activate=self:callback('delete_blueprint'),
                     enabled=function()
@@ -545,35 +545,8 @@ function Quickfort:on_transform_change(val)
     self.dirty = true
 end
 
-local origin, test_point = {x=0, y=0}, {x=1, y=-2}
-local minimal_sequence = {
-    ['x=1, y=-2'] = {},
-    ['x=2, y=-1'] = {'cw', 'flipv'},
-    ['x=2, y=1'] = {'cw'},
-    ['x=1, y=2'] = {'flipv'},
-    ['x=-1, y=2'] = {'cw', 'cw'},
-    ['x=-2, y=1'] = {'ccw', 'flipv'},
-    ['x=-2, y=-1'] = {'ccw'},
-    ['x=-1, y=-2'] = {'fliph'}
-}
-
--- reduces the list of transformations to a minimal sequence
-local function reduce_transform(elements)
-    local pos = test_point
-    for _,elem in ipairs(elements) do
-        pos = quickfort_transform.make_transform_fn_from_name(elem)(pos, origin)
-    end
-    local ret = quickfort_transform.resolve_vector(pos, minimal_sequence)
-    if #ret == #elements then
-        -- if we're not making the sequence any shorter, prefer the existing set
-        return elements
-    end
-    return copyall(ret)
-end
-
 function Quickfort:on_transform(val)
     table.insert(transformations, val)
-    transformations = reduce_transform(transformations)
     self:updateLayout()
     self.dirty = true
 end
@@ -684,12 +657,18 @@ function Quickfort:onRenderFrame(dc, rect)
     -- if the (non-locked) cursor has moved since last preview processing or any
     -- settings have changed, regenerate the preview
     local cursor = dfhack.gui.getMousePos() or self.saved_cursor
-    if self.dirty or not same_xyz(self.saved_cursor, cursor) then
-        if not self.cursor_locked then
-            self.saved_cursor = cursor
+    if not self.cursor_locked and not same_xyz(self.saved_cursor, cursor) then
+        self.saved_cursor = cursor
+        self.last_cursor_move_time = os.clock()
+        self.dirty = true
+    end
+
+    if self.dirty then
+        local now = os.clock()
+        if not self.last_cursor_move_time or (now - self.last_cursor_move_time > 0.1) then
+            self:refresh_preview()
+            self.dirty = false
         end
-        self:refresh_preview()
-        self.dirty = false
     end
 
     local tiles = self.saved_preview.tiles

quickfort.lua

@@ -93,9 +93,9 @@ setmetatable(action_switch, {__index=function() return do_help end})
 
 local args = {...}
 local action = table.remove(args, 1) or 'help'
-args.commands = argparse.stringList(action)
+args.commands = {action}
 
-local action_fn = action_switch[args.commands[1]]
+local action_fn = action_switch[action]
 
 if (action == 'run' or action == 'orders' or action == 'undo') and
         not dfhack.isMapLoaded() then