Skip to content

CNR: support init command#4278

Merged
TomOnTime merged 3 commits into
mainfrom
cnr-register-creds-metadata
May 18, 2026
Merged

CNR: support init command#4278
TomOnTime merged 3 commits into
mainfrom
cnr-register-creds-metadata

Conversation

@TomOnTime
Copy link
Copy Markdown
Collaborator

Summary

Register CredsMetadata for CNR so the provider is offered by the dnscontrol init wizard.

Fields mirror the entries in integrationTest/profiles.json.

CC: @KaiSchwarz-cnic

Test plan

  • go build ./... passes
  • dnscontrol init lists CNR as an option
  • Verify any // TODO: Verify annotations in the diff (e.g. PortalURL)

🤖 Generated with Claude Code

Register CredsMetadata so the CNR provider appears in the `dnscontrol init` wizard.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@KaiSchwarz-cnic
Copy link
Copy Markdown
Contributor

@TomOnTime can you add @AsifNawaz-cnic also as maintainer for CNR or at least invite him to this org so that I can handover the review to him? ty! :-)

@TomOnTime
Copy link
Copy Markdown
Collaborator Author

@TomOnTime can you add @AsifNawaz-cnic also as maintainer for CNR or at least invite him to this org so that I can handover the review to him? ty! :-)

Will do!

@AsifNawaz-cnic. Look for invites in your email inbox. Also, @fm is our "liaison to maintainers") who will reach out to you soon.

@KaiSchwarz-cnic KaiSchwarz-cnic requested review from AsifNawaz-cnic and removed request for KaiSchwarz-cnic May 18, 2026 15:11
@TomOnTime TomOnTime merged commit 490f205 into main May 18, 2026
26 of 27 checks passed
@TomOnTime TomOnTime deleted the cnr-register-creds-metadata branch May 18, 2026 15:12
@KaiSchwarz-cnic
Copy link
Copy Markdown
Contributor

@TomOnTime I am confused now by that merge. I mean, code changes look good but we did not confirm. I don't mind but that's ... confusing! :-D

@fm
Copy link
Copy Markdown

fm commented May 18, 2026

Hi @AsifNawaz-cnic (and thanks @KaiSchwarz-cnic!)

We want to make sure this is the address you'd like to be reached at regarding maintainer communications. Your email will not be public and will only be used the the project team to send out maintainer communications. Can you email dnscontrol at faisal dot fm from your preferred address?

As a maintainer, we’d like to remind you of your role and expectations we have so that everyone has a positive experience using dnscontrol:

  • Maintainers are expected to support their provider. If a maintainer is no longer able to maintain a provider, they should suggest a replacement or if no replacement is available, the maintainer shall let the maintainer liaison know so they can put out a call for volunteers.
  • Maintainers must be responsible to bug reports and PRs for their provider.
  • Maintainers should set up test accounts and periodically verify that all tests pass (pkg/js/parse_tests and integrationTest), especially when new features are added or changed in the core product.
  • Contributors are encouraged to add new tests and refine old ones. (Test-driven development is encouraged.)

If there is anything we can help with, or help unblock, as you maintain your provider please don’t hesitate to reach out.

@KaiSchwarz-cnic
Copy link
Copy Markdown
Contributor

KaiSchwarz-cnic commented May 18, 2026

Hey @fm ! Nice to meet you.

we can forward an email address to you that you can use. it is a group email address that ensures my team receives the email, but we can't send emails out using it. the responsible & available person of my team will then reply directly through his direct business address, I guess. Does that still fit your needs or do you need an email address that works for both reading and writing? I expect target communication security by that as well?

@fm
Copy link
Copy Markdown

fm commented May 18, 2026

That's totally fine!

@KaiSchwarz-cnic
Copy link
Copy Markdown
Contributor

Email went out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants