-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Description
From DUNE-DAQ/drunc#753
It would also be nice if the colorized text were more readable in a white-background terminal. I've attached a screenshot that hopefully shows that it is currently hard to read.
Pawel suggestion
For the request, unless there's a global way to make it dynamic (talking to the tty configuration, checking light vs dark mode (which I think is possible on linux but is fiddly), we have two options:
Define a command that changes the colors (note the config would need to be locally cloned, sloppy)
Change the color to be static and the same for everyone, which would be legible on both light and dark backgrounds
(personal choice) Define an env var that deals with this
The env var method could be interesting - we could have two separate configurations and a setup script that exports e.g. DUNEDAQ_TTY_MODE to be either nothing (assumes dark mode) or "light", that would allow more customizability. Then we could have separate configuration files for the color palletes. AFAIK you are a light mode user, so you could have free hand in choosing the colors 😉
This wouldn't be a particularly complex change to make either. A CLI entry point e.g. daqpytools_setup_logging_color_config could be used here
That way we don't need to have a local copy of the repo (edited)