Cannot find module '\workseet'

[strelov1]

After webpack build I got this error
Cannot find module '\workseet'

[colinroemer]

I am having the same issue. i believe its due to the way webpack is resolving these files imports that are using require(Path.join(__dirname, 'workbook'))

I am currently trying to determine if there is a way to adjust webpack to handle this

[DaSpawn]

I am unfortunately not too familiar with webpack, any suggestions are welcome. I took a quick look around and it may only require a config for webpack to resolve files, but not sure

[colinroemer]

@DaSpawn would it be possible to update the imports to use relative paths? I feel like this standard among most npm packages and should not cause issues.

[colinroemer]

@strelov1 how are you resolving modules in your webpack config?

[strelov1]

@strelov1 how are you resolving modules in your webpack config?

I replaced in this way, in my fork
const XlsxStreamReaderWorkBook = require(Path.join(__dirname, 'workbook'))
const XlsxStreamReaderWorkBook = require('./workbook')

[DaSpawn]

looks like that should not be a problem, but I need to test to be sure

[DaSpawn]

After some testing I just realized webpack would not work since this module relies on reading files with read streams, and browsers can not use the fs module. I can however still webpack the module to include the fs external, but it still requires node

I suspect this can be adapted to work in the browser/without read streams, but I have no time to work on right now

I will be pushing a new version shortly with webpack configs and compatible changes. I was able to build the module with webpack but I am unsure how to test/use and if it is even usable (but at least the webpack succeeds)

[strelov1]

@DaSpawn Thanks, but I don't use this package in browser. I build backend with webpack and use target node in webpack.config https://webpack.js.org/concepts/targets/

[DaSpawn]

ah, ok, I seen that but was not familiar with it. I will push the changes shortly and you can test, if all is good I can bump version in npm

edit: all set, changes just pushed (version numbers have not changed yet)

[colinroemer]

Thank you for looking into this so quickly!