From fc2624cc92c24d95f6cd69e52d111d9102b2cc32 Mon Sep 17 00:00:00 2001 From: Huy Nguyen Date: Wed, 1 Oct 2025 09:01:25 +0930 Subject: [PATCH 1/5] Trial update windows host version --- .github/workflows/generate_release_artifacts.yml | 4 ++-- .github/workflows/msbuild.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/generate_release_artifacts.yml b/.github/workflows/generate_release_artifacts.yml index 1172aa5..0864bca 100644 --- a/.github/workflows/generate_release_artifacts.yml +++ b/.github/workflows/generate_release_artifacts.yml @@ -137,8 +137,8 @@ build: #Project uses .NET Framework 4.6.2 which is not in later Github hosted runners - # See: https://github.com/actions/runner-images/blob/main/images/windows/Windows2019-Readme.md - runs-on: windows-2019 + # See: https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-Readme.md + runs-on: windows-2025 needs: [versioning] env: artifact-version: ${{ needs.versioning.outputs.artifact-version }} diff --git a/.github/workflows/msbuild.yml b/.github/workflows/msbuild.yml index 60173e9..3de18e2 100644 --- a/.github/workflows/msbuild.yml +++ b/.github/workflows/msbuild.yml @@ -33,8 +33,8 @@ permissions: jobs: build: #Project uses .NET Framework 4.6.2 which is not in later Github hosted runners - # See: https://github.com/actions/runner-images/blob/main/images/windows/Windows2019-Readme.md - runs-on: windows-2019 + # See: https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-Readme.md + runs-on: windows-2025 steps: - uses: actions/checkout@v4 From 9d532083975d4a316f10e0726d55d62a8c744a8d Mon Sep 17 00:00:00 2001 From: Huy Nguyen Date: Wed, 1 Oct 2025 09:05:48 +0930 Subject: [PATCH 2/5] Trigger action on beta branches --- .github/workflows/generate_release_artifacts.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/generate_release_artifacts.yml b/.github/workflows/generate_release_artifacts.yml index 0864bca..39009f3 100644 --- a/.github/workflows/generate_release_artifacts.yml +++ b/.github/workflows/generate_release_artifacts.yml @@ -7,7 +7,7 @@ on: push: - branches: [ "releases/**" ] + branches: [ "releases/**", "beta/**" ] tags: - v[0-9]+.[0-9]+.[0-9]+* env: From 64bae391a83123afa72dd0ad9c4b29b9c76c1908 Mon Sep 17 00:00:00 2001 From: Huy Nguyen Date: Wed, 1 Oct 2025 09:17:26 +0930 Subject: [PATCH 3/5] beta branch detection --- .github/workflows/generate_release_artifacts.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/generate_release_artifacts.yml b/.github/workflows/generate_release_artifacts.yml index 39009f3..9e32c44 100644 --- a/.github/workflows/generate_release_artifacts.yml +++ b/.github/workflows/generate_release_artifacts.yml @@ -80,14 +80,14 @@ run: echo "version=${{ steps.version_tag.outputs.full }}" >> $GITHUB_OUTPUT - name: Split branch name - if: ${{ (github.ref_type == 'branch') && startsWith(github.ref_name,'releases/v') }} + if: ${{ (github.ref_type == 'branch') && (startsWith(github.ref_name,'releases/v') || startsWith(github.ref_name,'beta/v'))}} env: BRANCH: ${{ github.ref_name }} id: version_branch run: echo "branch_version=${BRANCH:10}" >> $GITHUB_OUTPUT - name: Generate version from branch - if: ${{ steps.version_branch.outputs.branch_version && (github.ref_type == 'branch') && startsWith(github.ref_name,'releases/v') }} + if: ${{ steps.version_branch.outputs.branch_version && (github.ref_type == 'branch') && (startsWith(github.ref_name,'releases/v') || startsWith(github.ref_name,'beta/v')) }} id: version_branch_generate uses: HardNorth/github-version-generate@v1.4.0 with: From 6cf0f83d30d411ee86e4c2f525ecba985e8bb4af Mon Sep 17 00:00:00 2001 From: Huy Nguyen Date: Wed, 1 Oct 2025 09:33:09 +0930 Subject: [PATCH 4/5] Improved version extraction https://stackoverflow.com/questions/73402042/github-action-expressions-split-string --- .github/workflows/generate_release_artifacts.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/generate_release_artifacts.yml b/.github/workflows/generate_release_artifacts.yml index 9e32c44..cd9a5e0 100644 --- a/.github/workflows/generate_release_artifacts.yml +++ b/.github/workflows/generate_release_artifacts.yml @@ -84,7 +84,7 @@ env: BRANCH: ${{ github.ref_name }} id: version_branch - run: echo "branch_version=${BRANCH:10}" >> $GITHUB_OUTPUT + run: echo "branch_version=${BRANCH##*/}" >> $GITHUB_OUTPUT - name: Generate version from branch if: ${{ steps.version_branch.outputs.branch_version && (github.ref_type == 'branch') && (startsWith(github.ref_name,'releases/v') || startsWith(github.ref_name,'beta/v')) }} From e6158cefecc86a85bb04731f99e511ca817f0b43 Mon Sep 17 00:00:00 2001 From: Huy Nguyen Date: Wed, 1 Oct 2025 11:56:30 +0930 Subject: [PATCH 5/5] Remove v from semantic version detected --- .github/workflows/generate_release_artifacts.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/generate_release_artifacts.yml b/.github/workflows/generate_release_artifacts.yml index cd9a5e0..e83306d 100644 --- a/.github/workflows/generate_release_artifacts.yml +++ b/.github/workflows/generate_release_artifacts.yml @@ -84,7 +84,7 @@ env: BRANCH: ${{ github.ref_name }} id: version_branch - run: echo "branch_version=${BRANCH##*/}" >> $GITHUB_OUTPUT + run: echo "branch_version=${BRANCH##*/v}" >> $GITHUB_OUTPUT - name: Generate version from branch if: ${{ steps.version_branch.outputs.branch_version && (github.ref_type == 'branch') && (startsWith(github.ref_name,'releases/v') || startsWith(github.ref_name,'beta/v')) }}