Skip to content

Umbrella: roll out ErrorBoundary provider-nesting fix to all findable-ui clients #888

@NoopDog

Description

@NoopDog

Summary

data-browser#4783 fixes an infinite crash loop that occurs when a filter query parameter contains an invalid value. The root cause is structural: ExploreStateProvider, DataDictionaryStateProvider, and FileManifestStateProvider were positioned above the ErrorBoundary in pages/_app.tsx, so reducer/hook errors in those providers bypassed the boundary and bubbled up to Next.js, which re-rendered and hit the same crash again.

The fix moves the three providers inside the ErrorBoundary. Header and Footer stay outside so users can still navigate away from the error page. The Error fallback does not consume these provider states, so nothing needs to change beyond the tree order.

Before:                          After:
ExploreStateProvider             Main
  DataDictionaryStateProvider      ErrorBoundary ← catches all errors below
    Main                             ExploreStateProvider
      ErrorBoundary                    DataDictionaryStateProvider
        FileManifestStateProvider        FileManifestStateProvider
          Component                        Component

Any findable-ui consumer with the same pages/_app.tsx shape is exposed to the same crash loop and should pick up this fix.

Ask

@frano-m — please create a sub-issue on this umbrella for each findable-ui client that needs the fix applied, audit their pages/_app.tsx for the same provider/ErrorBoundary ordering, and track rollout here.

Reference

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions