Summary
When a metadata dictionary page receives malformed filter query parameters, the behavior is inconsistent:
- Using
"terms" key (e.g. ?filter=[{"id":"required","terms":["Recommended"]}]): Crashes with Cannot read properties of undefined (reading 'some'). This is caught by ErrorBoundary if positioned correctly.
- Using
"value" key (e.g. ?filter=[{"id":"required","value":...}): Silently fails — no error, no crash, but the filter is not applied.
Expected behavior
Both cases should either:
- Gracefully ignore the malformed param and render the page without the filter, or
- Surface a user-visible error
The silent failure case is concerning because users may not realize their filter isn't being applied.
Context
Discovered while testing the ErrorBoundary provider-nesting fix (#888) in data-portal (DataBiosphere/data-portal#3015).
Summary
When a metadata dictionary page receives malformed filter query parameters, the behavior is inconsistent:
"terms"key (e.g.?filter=[{"id":"required","terms":["Recommended"]}]): Crashes withCannot read properties of undefined (reading 'some'). This is caught byErrorBoundaryif positioned correctly."value"key (e.g.?filter=[{"id":"required","value":...}): Silently fails — no error, no crash, but the filter is not applied.Expected behavior
Both cases should either:
The silent failure case is concerning because users may not realize their filter isn't being applied.
Context
Discovered while testing the
ErrorBoundaryprovider-nesting fix (#888) in data-portal (DataBiosphere/data-portal#3015).