Skip to content

DataDictionaryStateProvider silently ignores malformed filter query params #892

@frano-m

Description

@frano-m

Summary

When a metadata dictionary page receives malformed filter query parameters, the behavior is inconsistent:

  • Using "terms" key (e.g. ?filter=[{"id":"required","terms":["Recommended"]}]): Crashes with Cannot read properties of undefined (reading 'some'). This is caught by ErrorBoundary if positioned correctly.
  • Using "value" key (e.g. ?filter=[{"id":"required","value":...}): Silently fails — no error, no crash, but the filter is not applied.

Expected behavior

Both cases should either:

  1. Gracefully ignore the malformed param and render the page without the filter, or
  2. Surface a user-visible error

The silent failure case is concerning because users may not realize their filter isn't being applied.

Context

Discovered while testing the ErrorBoundary provider-nesting fix (#888) in data-portal (DataBiosphere/data-portal#3015).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions