From 041d2cc59bb21687d3758465f71e9c421eb1d161 Mon Sep 17 00:00:00 2001
From: Arthur Belleville <arthur.belleville@datadoghq.com>
Date: Wed, 28 Aug 2024 09:52:20 +0200
Subject: [PATCH] Optimise should_bypass method

---
 sds/src/proximity_keywords/mod.rs | 28 +++++-----------------------
 1 file changed, 5 insertions(+), 23 deletions(-)

diff --git a/sds/src/proximity_keywords/mod.rs b/sds/src/proximity_keywords/mod.rs
index 2e8176b1..265fc594 100644
--- a/sds/src/proximity_keywords/mod.rs
+++ b/sds/src/proximity_keywords/mod.rs
@@ -286,30 +286,12 @@ pub enum BypassStandardizePathResult {
     NoBypass,
 }
 
-pub fn should_bypass_standardize_path(characters: &str) -> BypassStandardizePathResult {
-    let mut all_lower = true;
-    let mut all_upper = true;
-    for char in characters.chars() {
-        let is_upper = char.is_ascii_uppercase();
-        let is_lower = char.is_ascii_lowercase();
-        // If it's neither an uppercase character nor a lowercase character, return NoBypass
-        if !is_lower && !is_upper {
-            return BypassStandardizePathResult::NoBypass;
-        }
-        all_lower = all_lower && is_lower;
-        all_upper = all_upper && is_upper;
-        // If we realise that we don't have all uppercase nor all lowercase, return NoBypass
-        if !all_lower && !all_upper {
-            return BypassStandardizePathResult::NoBypass;
-        }
-    }
-
-    // The characters contain only uppercase characters or only lowercase characters by now, so we can bypass
-    if all_lower {
-        BypassStandardizePathResult::BypassAndAllLowercase
+pub fn should_bypass_standardize_path(s: &str) -> BypassStandardizePathResult {
+    return if s.chars().position(|c| !c.is_ascii_lowercase()).is_some() {
+        BypassStandardizePathResult::NoBypass
     } else {
-        BypassStandardizePathResult::BypassAndAllUppercase
-    }
+        BypassStandardizePathResult::BypassAndAllLowercase
+    };
 }
 
 /// Function that standardizes a list of characters, by pushing characters one by one in a standard way.