Report Kafka client connection status in DSM payloads#11442
Draft
piochelepiotr wants to merge 1 commit into
Draft
Report Kafka client connection status in DSM payloads#11442piochelepiotr wants to merge 1 commit into
piochelepiotr wants to merge 1 commit into
Conversation
Previously, the DSM payload only carried Kafka client configs once
`Metadata.update` fired with a valid cluster ID — so clients that never
authenticated or never reached a broker were silently dropped, and we
couldn't compare their configs against working clients.
Now every config is also reported with a `connectionStatus` field
("connected" / "failed") on the per-bucket `Configs` entry, including
on `Metadata.failedUpdate`. Also expands the value-allowlist with
non-secret auth selectors (`sasl.mechanism`, `ssl.protocol`,
`ssl.endpoint.identification.algorithm`, etc.) so the comparison flow
can surface mechanism typos without leaking credentials.
tag: ai generated
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
piochelepiotr
added
type: enhancement
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectionStatusfield (connected/failed) inside the DSM msgpack payload (Configs[*].ConnectionStatus, peer toType,KafkaClusterId,ConsumerGroup,Config).org.apache.kafka.clients.Metadata.failedUpdatein bothkafka-clients-0.11andkafka-clients-3.8so failed clients are reported (previously they were silently dropped — reporting was gated onMetadata.updatesucceeding).sasl.mechanism,ssl.protocol,ssl.enabled.protocols,ssl.endpoint.identification.algorithm,ssl.truststore.type,ssl.keystore.type,ssl.cipher.suites,sasl.kerberos.service.name,sasl.login.callback.handler.class). Credentials remain masked.Why
End goal is a DSM UI flow where a user can diff a failing client's config against working clients on the same cluster — typoed
bootstrap.servers, missingsasl.mechanism, SSL truststore drift, etc. Without capturing failed clients at all, the comparison is impossible today.Downstream
connection_statuscolumn + 8th positional proc param withDEFAULT 'connected')Test plan
DataStreamsWritingTest,DefaultDataStreamsMonitoringTest,KafkaConfigHelperTest)Reporting kafka_producer config with status=connectedfor a working producer/consumer andstatus=failedfor a producer pointed at a closed port; agent forwards both to/v0.1/pipeline_stats.Known gap (follow-up)
A client whose
bootstrap.serversfails at constructor DNS-resolve time (e.g.bogus.invalid:9092) reports nothing — the producer never builds, so noMetadataever exists. Adding@Advice.OnMethodExit(onThrowable=...)on the producer constructor would close that gap.tag: ai generated
🤖 Generated with Claude Code