Background dialog test: wait for Qt events to be processed

Author: PierreRaybaut

datalab/tests/features/images/background_dialog_test.py

@@ -14,14 +14,26 @@
 import sigima.objects
 import sigima.params
 import sigima.proc.image as sigima_image
-from guidata.qthelpers import exec_dialog, qt_app_context
+from guidata.qthelpers import exec_dialog, qt_app_context, qt_wait_until
 from sigima.tests import vistools
 from sigima.tests.data import create_noisygauss_image
 
 from datalab.env import execenv
 from datalab.widgets.imagebackground import ImageBackgroundDialog
 
 
+def wait_for_rect_coords(dlg: ImageBackgroundDialog) -> bool:
+    """Condition to wait for rectangle coordinates."""
+    # Wait for rectangle coordinates to be set. This is necessary because
+    # when executing the dialog in unattended mode, the rectangle
+    # coordinates may not be set immediately (Qt events may not be processed).
+    try:
+        dlg.get_rect_coords()
+        return True
+    except ValueError:
+        return False
+
+
 def test_image_background_selection() -> None:
     """Image background selection test."""
     with qt_app_context():
@@ -30,6 +42,7 @@ def test_image_background_selection() -> None:
         dlg.resize(640, 480)
         dlg.setObjectName(dlg.objectName() + "_00")  # to avoid timestamp suffix
         exec_dialog(dlg)
+        qt_wait_until(lambda: wait_for_rect_coords(dlg))
         execenv.print(f"background: {dlg.get_background()}")
         execenv.print(f"rect coords: {dlg.get_rect_coords()}")
         # Check background value:
@@ -45,6 +58,7 @@ def test_image_offset_correction_with_background_dialog() -> None:
         dlg = ImageBackgroundDialog(i1)
         ok = exec_dialog(dlg)
         if ok:
+            qt_wait_until(lambda: wait_for_rect_coords(dlg))
             param = sigima.objects.ROI2DParam()
             # pylint: disable=unbalanced-tuple-unpacking
             ix0, iy0, ix1, iy1 = i1.physical_to_indices(dlg.get_rect_coords())

datalab/widgets/imagebackground.py

@@ -81,6 +81,14 @@ def get_background(self) -> float:
         return self.__background
 
     def get_rect_coords(self) -> tuple[float, float, float, float]:
-        """Get rectangle coordinates"""
-        assert self.__rect_coords is not None, "Rectangle coordinates not set"
+        """Get rectangle coordinates
+
+        Returns:
+            tuple: rectangle coordinates (x0, y0, x1, y1)
+
+        Raises:
+            ValueError: if rectangle coordinates are not set
+        """
+        if self.__rect_coords is None:
+            raise ValueError("Rectangle coordinates not set")
         return self.__rect_coords