Skip to content

Commit 53e0acd

Browse files
committed
Changed select_objects arguments
1 parent 99783c5 commit 53e0acd

3 files changed

Lines changed: 9 additions & 12 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Changes:
99
* Renamed `switch_to_panel` method to `set_current_panel` (compatibility with DataLab 0.9)
1010
* Added `get_current_panel` method
1111
* Changed `select_groups` first argument `selection` (compatibility with DataLab 0.9)
12+
* Changed `select_objects` arguments (compatibility with DataLab 0.9)
1213

1314
## Version 0.3.0 ##
1415

cdlclient/baseproxy.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -235,16 +235,14 @@ def get_sel_object_uuids(self, include_groups: bool = False) -> list[str]:
235235
def select_objects(
236236
self,
237237
selection: list[int | str],
238-
group_num: int | None = None,
239238
panel: str | None = None,
240239
) -> None:
241240
"""Select objects in current panel.
242241
243242
Args:
244-
selection (list[int | str]): List of object indices or uuids to select
245-
group_num (int | None): Group number. Defaults to None.
246-
panel (str | None): panel name (valid values: "signal", "image").
247-
If None, current panel is used. Defaults to None.
243+
selection: List of object numbers (1 to N) or uuids to select
244+
panel: panel name (valid values: "signal", "image").
245+
If None, current panel is used. Defaults to None.
248246
"""
249247

250248
@abc.abstractmethod
@@ -512,18 +510,16 @@ def get_sel_object_uuids(self, include_groups: bool = False) -> list[str]:
512510
def select_objects(
513511
self,
514512
selection: list[int | str],
515-
group_num: int | None = None,
516513
panel: str | None = None,
517514
) -> None:
518515
"""Select objects in current panel.
519516
520517
Args:
521-
selection (list[int | str]): List of object indices or uuids to select
522-
group_num (int | None): Group number. Defaults to None.
523-
panel (str | None): panel name (valid values: "signal", "image").
524-
If None, current panel is used. Defaults to None.
518+
selection: List of object numbers (1 to N) or uuids to select
519+
panel: panel name (valid values: "signal", "image").
520+
If None, current panel is used. Defaults to None.
525521
"""
526-
self._cdl.select_objects(selection, group_num, panel)
522+
self._cdl.select_objects(selection, panel)
527523

528524
def select_groups(
529525
self, selection: list[int | str] | None = None, panel: str | None = None

cdlclient/tests/remoteclient_app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ def test_remote_client():
280280
with qt_wait_print(dt, "Getting object uuids"):
281281
window.get_object_uuids()
282282
with qt_wait_print(dt, "Getting object"):
283-
window.cdl.select_objects([0])
283+
window.cdl.select_objects([1])
284284
window.get_object()
285285
with qt_wait_print(dt, "Adding signals"):
286286
window.add_signals()

0 commit comments

Comments
 (0)