-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Enforce SVN fingerprint byte cap during reads #1123
Copy link
Copy link
Open
Labels
editor/integrationEditor compatibility and CLI integrationEditor compatibility and CLI integrationenhancementNew feature or requestNew feature or requestpriority/normalStandard review queue; useful PR with ordinary maintainer urgency.Standard review queue; useful PR with ordinary maintainer urgency.stability/performanceServer crashes, OOM, hangs, high CPU/memoryServer crashes, OOM, hangs, high CPU/memorytaskUmbrella task grouping multiple related issuesUmbrella task grouping multiple related issuesux/behaviorDisplay bugs, docs, adoption UXDisplay bugs, docs, adoption UX
Milestone
Description
Metadata
Metadata
Assignees
Labels
editor/integrationEditor compatibility and CLI integrationEditor compatibility and CLI integrationenhancementNew feature or requestNew feature or requestpriority/normalStandard review queue; useful PR with ordinary maintainer urgency.Standard review queue; useful PR with ordinary maintainer urgency.stability/performanceServer crashes, OOM, hangs, high CPU/memoryServer crashes, OOM, hangs, high CPU/memorytaskUmbrella task grouping multiple related issuesUmbrella task grouping multiple related issuesux/behaviorDisplay bugs, docs, adoption UXDisplay bugs, docs, adoption UX
Related to #1113.
SVN fingerprinting checks the file size before opening, but then reads until EOF. A file that grows concurrently can exceed the configured fingerprint byte cap and consume unbounded watcher-cycle time and I/O.
Track cumulative bytes while reading, stop at the existing cap, and validate size from the opened handle where possible. Add coverage for a file that grows after the initial metadata check.