-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Make SVN fingerprint opens race-safe #1124
Copy link
Copy link
Open
Labels
editor/integrationEditor compatibility and CLI integrationEditor compatibility and CLI integrationenhancementNew feature or requestNew feature or requestpriority/normalStandard review queue; useful PR with ordinary maintainer urgency.Standard review queue; useful PR with ordinary maintainer urgency.securitySecurity vulnerabilities, hardeningSecurity vulnerabilities, hardeningtaskUmbrella task grouping multiple related issuesUmbrella task grouping multiple related issues
Milestone
Description
Metadata
Metadata
Assignees
Labels
editor/integrationEditor compatibility and CLI integrationEditor compatibility and CLI integrationenhancementNew feature or requestNew feature or requestpriority/normalStandard review queue; useful PR with ordinary maintainer urgency.Standard review queue; useful PR with ordinary maintainer urgency.securitySecurity vulnerabilities, hardeningSecurity vulnerabilities, hardeningtaskUmbrella task grouping multiple related issuesUmbrella task grouping multiple related issues
Related to #1113.
The SVN fingerprint path checks run before ordinary
fopen/opendircalls. A concurrent path swap can therefore replace a previously validated regular file or directory with a symlink, reparse point, special file, or path outside the working-copy root before it is opened.Use no-follow, handle-relative opens where supported, or validate the opened handle identity and containment before reading. Add a regression test that swaps the candidate between validation and open.