Skip to content

Make SVN fingerprint opens race-safe #1124

Description

@lzl51230

Related to #1113.

The SVN fingerprint path checks run before ordinary fopen/opendir calls. A concurrent path swap can therefore replace a previously validated regular file or directory with a symlink, reparse point, special file, or path outside the working-copy root before it is opened.

Use no-follow, handle-relative opens where supported, or validate the opened handle identity and containment before reading. Add a regression test that swaps the candidate between validation and open.

Metadata

Metadata

Assignees

No one assigned

    Labels

    editor/integrationEditor compatibility and CLI integrationenhancementNew feature or requestpriority/normalStandard review queue; useful PR with ordinary maintainer urgency.securitySecurity vulnerabilities, hardeningtaskUmbrella task grouping multiple related issues

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions