From db4c56c5c24d141b5c14851d2432f11fc99119cf Mon Sep 17 00:00:00 2001 From: yxd92326 Date: Thu, 4 Sep 2025 10:35:02 +0100 Subject: [PATCH] More logs for rsyncer --- src/murfey/client/rsync.py | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/murfey/client/rsync.py b/src/murfey/client/rsync.py index 52facd0db..0002cd488 100644 --- a/src/murfey/client/rsync.py +++ b/src/murfey/client/rsync.py @@ -421,6 +421,8 @@ def parse_stdout(line: str): # This marks the start of a transfer, wait for the progress line next_file = update return + logger.warning(f"Unknown line from rsync {line}") + return def parse_stderr(line: str): if line.strip(): @@ -563,13 +565,19 @@ def parse_stderr(line: str): self.notify(update) success = False - if result is None: + if result is None and files: # Only log this as an error if files were scheduled for transfer - if files: - logger.error(f"No rsync process ran for files: {files}") - else: - logger.log( - logging.WARNING if result.returncode else logging.DEBUG, + logger.error(f"No rsync process ran for files: {files}") + elif result and result.returncode: + logger.warning( f"rsync process finished with return code {result.returncode}", ) + elif not success: + logger.info( + "rsync process failed for some files: " + f"requested {len(relative_filenames)}, transferred {len(transfer_success)}", + ) + else: + logger.debug("rsync process finished successfully") + return success