Skip to content

Avoid null pointer while extracting plist root dictionary #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DropSnorz merged 1 commit into from
Apr 27, 2026
Merged

Avoid null pointer while extracting plist root dictionary #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions ...lug-client/src/main/java/com/owlplug/plugin/tasks/discovery/fileformats/OsxPlistFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class OsxPlistFile {

private final Logger log = LoggerFactory.getLogger(this.getClass());

private File plist;
private final File plist;

public OsxPlistFile(File plist) {
super();
Expand All @@ -44,11 +44,27 @@ public OsxPlistFile(File plist) {


public void bindProperties(Plugin plugin) {

try {
NSDictionary rootDict = (NSDictionary) PropertyListParser.parse(plist);
// Ensure plist class constructor input is not null
if (plist == null) {
log.error("Plist file/input is null, cannot bind properties.");
return;
}

NSObject rootObject = PropertyListParser.parse(plist);

// Ensure parsed result is a NSDictionary
// Some execution shown that it could be null
if (!(rootObject instanceof NSDictionary)) {
log.error("Plist root is not a NSDictionary, actual type: {}",
rootObject == null ? "null" : rootObject.getClass().getName());
return;
}

NSDictionary rootDict = (NSDictionary) rootObject;

NSObject nsBundleId = rootDict.objectForKey("CFBundleIdentifier");
NSObject nsBundleVersion = rootDict.objectForKey("CFBun" + "dleShortVersionString");
NSObject nsBundleVersion = rootDict.objectForKey("CFBundleShortVersionString");

if (nsBundleVersion == null) {
nsBundleVersion = rootDict.objectForKey("CFBundleVersion");
Expand All @@ -59,9 +75,10 @@ public void bindProperties(Plugin plugin) {
if (nsBundleVersion != null) {
plugin.setVersion(nsBundleVersion.toString());
}
} catch (IOException | PropertyListFormatException | ParseException | ParserConfigurationException
| SAXException e) {
log.error("Error while binding plugin properties from Plist file", e);

} catch (IOException | PropertyListFormatException | ParseException
| ParserConfigurationException | SAXException e) {
log.error("Error while binding plugin properties from Plist file", e);
}
}
}