Skip to content

Run system file and browser opening asynchronously #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DropSnorz merged 1 commit into from
May 20, 2026
Merged

Run system file and browser opening asynchronously #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 34 additions & 18 deletions owlplug-client/src/main/java/com/owlplug/core/utils/PlatformUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
import java.util.concurrent.TimeUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -43,28 +44,43 @@ public static void openFromDesktop(String path) {
}

public static void openFromDesktop(File file) {
try {
Desktop.getDesktop().open(file);
} catch (IOException e) {
log.error("Application for the given file fails to be launched", e);
}
Async.run(() -> {
if (!Desktop.isDesktopSupported() || !Desktop.getDesktop().isSupported(Action.OPEN)) {
log.warn("Desktop API not supported, cannot open file: {}", file.getAbsolutePath());
return;
}
try {
Desktop.getDesktop().open(file);
} catch (IOException e) {
log.error("Application for the given file fails to be launched", e);
}
});
}

public static void openDefaultBrowser(String url) {

try {
log.debug("Opening address " + url + " in default browser");
if (Desktop.isDesktopSupported() && Desktop.getDesktop().isSupported(Action.BROWSE)) {
Desktop.getDesktop().browse(new URI(url));
}
else {
new ProcessBuilder("xdg-open", url).start();
Async.run(() -> {
try {
log.debug("Opening address {} in default browser", url);
if (Desktop.isDesktopSupported() && Desktop.getDesktop().isSupported(Action.BROWSE)) {
Desktop.getDesktop().browse(new URI(url));
} else {
log.warn("Desktop API not supported, falling back to xdg-open");
Process process = new ProcessBuilder("xdg-open", url).start();
if (!process.waitFor(5, TimeUnit.SECONDS)) {
process.destroyForcibly();
log.warn("xdg-open timed out for URL: {}", url);
} else if (process.exitValue() != 0) {
log.error("xdg-open failed for URL: {} (exit code {})", url, process.exitValue());
}
}
} catch (IOException e) {
log.error("Can't open default browser for URL: {}", url, e);
} catch (URISyntaxException e) {
log.error("Invalid URI: {}", url);
} catch (InterruptedException e) {
log.error("Thread interrupted while waiting for xdg-open to finish", e);
}
} catch (IOException e) {
log.error("Can't open default browser");
} catch (URISyntaxException e) {
log.error("Error in URI:" + url);
}
});
}

}
Loading