refactor(vmm): drop validate_tee_image_mode check

no-TEE mode does not need an is_dev image gate; remove the helper,
call sites, and unit test.

Author: kvinwang

dstack/vmm/src/app.rs

@@ -74,13 +74,6 @@ pub struct Manifest {
     pub networking: Option<Networking>,
 }
 
-pub(crate) fn validate_tee_image_mode(no_tee: bool, image_is_dev: bool) -> Result<()> {
-    if no_tee && !image_is_dev {
-        bail!("no-TEE mode requires a development image");
-    }
-    Ok(())
-}
-
 #[derive(Debug, Clone, Serialize, Deserialize, Default)]
 #[serde(rename_all = "snake_case")]
 pub enum AttachMode {
@@ -282,7 +275,6 @@ impl App {
         }
         let image_path = self.config.image.path.join(&manifest.image);
         let image = Image::load(&image_path).context("Failed to load image")?;
-        validate_tee_image_mode(manifest.no_tee, image.info.is_dev)?;
         let vm_id = manifest.id.clone();
         let app_compose = vm_work_dir
             .app_compose()
@@ -862,7 +854,6 @@ impl App {
         }
         let image_path = self.config.image.path.join(&manifest.image);
         let image = Image::load(&image_path).context("Failed to load image")?;
-        validate_tee_image_mode(manifest.no_tee, image.info.is_dev)?;
         let vm_id = manifest.id.clone();
         let already_running = cids_assigned.contains_key(&vm_id);
         let app_compose = vm_work_dir
@@ -1631,14 +1622,6 @@ mod tests {
         assert_eq!(effective_vcpu_count(0, Some(1)), 1);
     }
 
-    #[test]
-    fn no_tee_requires_a_development_image() {
-        assert!(validate_tee_image_mode(false, false).is_ok());
-        assert!(validate_tee_image_mode(false, true).is_ok());
-        assert!(validate_tee_image_mode(true, true).is_ok());
-        assert!(validate_tee_image_mode(true, false).is_err());
-    }
-
     #[test]
     fn effective_vcpu_count_rounds_for_hugepage_numa_split() {
         assert_eq!(effective_vcpu_count(3, Some(2)), 4);

dstack/vmm/src/one_shot.rs

@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-use crate::app::{make_sys_config, validate_tee_image_mode, Image, VmConfig, VmWorkDir};
+use crate::app::{make_sys_config, Image, VmConfig, VmWorkDir};
 use crate::config::Config;
 use crate::main_service;
 use anyhow::{Context, Result};
@@ -82,7 +82,6 @@ pub async fn run_one_shot(
     let image_path = config.image.path.join(&manifest.image);
     let image = Image::load(&image_path)
         .with_context(|| format!("Failed to load image: {}", image_path.display()))?;
-    validate_tee_image_mode(manifest.no_tee, image.info.is_dev)?;
 
     // Create or use specified workdir and setup files
     let workdir_path = match workdir_option {