[Bug Fix] Fix number of dots per segment#432
Open
shraddha-bajare wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #403
Root Cause:
The bug is a mismatch between what
Radar.jsxrenders and what theAboutpage documents.e.g
resquihas all three tiers (rs:AnalysisCode, rs:PrototypeTool, rs:ResearchInfrastructureSoftware) andfunctional_suitabilityas a dimension — so the radar renders 3 dots (one per tier). But when the segment is clicked, Home.jsx's filteredTools correctly returns only 1 tool (since resqui is a single entry).So the dot count and the list count are structurally inconsistent.
As per decision About page says:If a tool applies to multiple tiers, it is placed in the lowest applicable tier.but the code places it in all applicable tiers.
Fix applied:
In Radar.jsx, replace the multi-tier push with a single minimum tier. This makes the dot count equal to the tool count per segment, so clicking "Functional Stability" shows 1 tool and 1 dot — consistent with the About page