fix: make phase 7 cleanup reversible#331
Open
sjh9714 wants to merge 2 commits into
Open
Conversation
3b7fa15 to
5e85308
Compare
Author
|
Rebased this onto the latest Verified locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #301.
Phase 7 no longer asks the host shell to immediately delete freshly-created
.understand-anything/intermediateandtmpwork directories. Instead, it calls a bundled cleanup script that moves those directories into timestamped.trash-*directories and only purges trash older than seven days.Changes
cleanup-workdirs.mjsto moveintermediate/andtmp/into reversible trash and prune expired trash./understandPhase 7 to call the bundled cleanup script.2.7.6per the repository versioning note.Testing
pnpm installnode --check understand-anything-plugin/skills/understand/cleanup-workdirs.mjspnpm vitest run tests/skill/understand/test_cleanup_workdirs.test.mjspnpm lintpnpm testpnpm --filter @understand-anything/core testpnpm --filter @understand-anything/skill buildpnpm buildgit diff --checkNote: I used Codex while preparing this change, reviewed the final diff, and ran the listed checks locally.