From 026602e6247d63a83502b80e72cd318232a06af7 Mon Sep 17 00:00:00 2001 From: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Date: Fri, 13 Mar 2026 09:28:05 -0700 Subject: [PATCH] fix(skills): use fully-qualified agent namespace in Task invocations Rebased onto main after #251 restructured commands into skills/. Applied the same namespace fix to the new skill file locations (ce-brainstorm, ce-plan, ce-review SKILL.md files). Short agent names like `repo-research-analyst` are replaced with fully-qualified `compound-engineering:research:repo-research-analyst` to ensure correct agent resolution across all plugin targets. Co-Authored-By: Claude Opus 4.6 --- .../skills/ce-brainstorm/SKILL.md | 2 +- plugins/compound-engineering/skills/ce-plan/SKILL.md | 8 ++++---- .../compound-engineering/skills/ce-review/SKILL.md | 12 ++++++------ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/plugins/compound-engineering/skills/ce-brainstorm/SKILL.md b/plugins/compound-engineering/skills/ce-brainstorm/SKILL.md index 8527a4ed..2649c158 100644 --- a/plugins/compound-engineering/skills/ce-brainstorm/SKILL.md +++ b/plugins/compound-engineering/skills/ce-brainstorm/SKILL.md @@ -41,7 +41,7 @@ Use **AskUserQuestion tool** to suggest: "Your requirements seem detailed enough Run a quick repo scan to understand existing patterns: -- Task repo-research-analyst("Understand existing patterns related to: ") +- Task compound-engineering:research:repo-research-analyst("Understand existing patterns related to: ") Focus on: similar features, established patterns, CLAUDE.md guidance. diff --git a/plugins/compound-engineering/skills/ce-plan/SKILL.md b/plugins/compound-engineering/skills/ce-plan/SKILL.md index 29761aa7..b5d7e1e0 100644 --- a/plugins/compound-engineering/skills/ce-plan/SKILL.md +++ b/plugins/compound-engineering/skills/ce-plan/SKILL.md @@ -82,8 +82,8 @@ First, I need to understand the project's conventions, existing patterns, and an Run these agents **in parallel** to gather local context: -- Task repo-research-analyst(feature_description) -- Task learnings-researcher(feature_description) +- Task compound-engineering:research:repo-research-analyst(feature_description) +- Task compound-engineering:research:learnings-researcher(feature_description) **What to look for:** - **Repo research:** existing patterns, CLAUDE.md guidance, technology familiarity, pattern consistency @@ -113,8 +113,8 @@ Examples: Run these agents in parallel: -- Task best-practices-researcher(feature_description) -- Task framework-docs-researcher(feature_description) +- Task compound-engineering:research:best-practices-researcher(feature_description) +- Task compound-engineering:research:framework-docs-researcher(feature_description) ### 1.6. Consolidate Research diff --git a/plugins/compound-engineering/skills/ce-review/SKILL.md b/plugins/compound-engineering/skills/ce-review/SKILL.md index 65aebffc..e72d7b37 100644 --- a/plugins/compound-engineering/skills/ce-review/SKILL.md +++ b/plugins/compound-engineering/skills/ce-review/SKILL.md @@ -109,8 +109,8 @@ For each agent in review_agents: ``` Always run these last regardless of mode: -- Task agent-native-reviewer(PR content) - Verify new features are agent-accessible -- Task learnings-researcher(PR content) - Search docs/solutions/ for past issues related to this PR's modules and patterns +- Task compound-engineering:review:agent-native-reviewer(PR content) - Verify new features are agent-accessible +- Task compound-engineering:research:learnings-researcher(PR content) - Search docs/solutions/ for past issues related to this PR's modules and patterns @@ -122,9 +122,9 @@ These agents are run ONLY when the PR matches specific criteria. Check the PR fi **MIGRATIONS: If PR contains database migrations, schema.rb, or data backfills:** -- Task schema-drift-detector(PR content) - Detects unrelated schema.rb changes by cross-referencing against included migrations (run FIRST) -- Task data-migration-expert(PR content) - Validates ID mappings match production, checks for swapped values, verifies rollback safety -- Task deployment-verification-agent(PR content) - Creates Go/No-Go deployment checklist with SQL verification queries +- Task compound-engineering:review:schema-drift-detector(PR content) - Detects unrelated schema.rb changes by cross-referencing against included migrations (run FIRST) +- Task compound-engineering:review:data-migration-expert(PR content) - Validates ID mappings match production, checks for swapped values, verifies rollback safety +- Task compound-engineering:review:deployment-verification-agent(PR content) - Creates Go/No-Go deployment checklist with SQL verification queries **When to run:** - PR includes files matching `db/migrate/*.rb` or `db/schema.rb` @@ -236,7 +236,7 @@ Complete system context map with component interactions ### 4. Simplification and Minimalism Review -Run the Task code-simplicity-reviewer() to see if we can simplify the code. +Run the Task compound-engineering:review:code-simplicity-reviewer() to see if we can simplify the code. ### 5. Findings Synthesis and Todo Creation Using file-todos Skill