Expense - Potential duplicate message is shown in header for paid expense briefly

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.60-17
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84657
Email or phone of affected tester (no customers): dreamnitethedragon+vegst@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open workspace chat
3. Create 2 distance manual expense
4. Open the expense report
5. Submit, approve and pay the expense
6. Select both expense and duplicate expenses
7. Navigate back to remove selection and note header message
8. Open the expense and note header message

Expected Result:

Potential duplicate message must not shown in header for paid expense briefly on duplicate expenses.

Actual Result:

Potential duplicate message is shown in header for paid expense briefly on duplicate expenses.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #84657

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #84657 - "[Duplicate Expense] Allow bulk duplication." by @Krishna2323 (High confidence)
Related Issues: #84281

Recommendation: REVERT

PR #84657 introduced the bulk duplication feature and is directly implicated by melvin-bot's automated assignment. The bug is a UX regression introduced by this PR where the "Potential duplicate" message briefly appears in the header for paid expenses after performing a bulk duplication.

Assigned: @Krishna2323 (PR author), @situchan (approving reviewer), @JS00001 (approving reviewer)
Labels: DeployBlockerCash kept (App PR caused the issue). No label changes made.

Detailed Analysis

Evidence

• The issue body explicitly references PR [Duplicate Expense] Allow bulk duplication.  #84657 in the regression test field: "If this was caught during regression testing, add the test name, ID and link from BrowserStack: [Duplicate Expense] Allow bulk duplication.  #84657"
• melvin-bot automatically assigned the issue to PR [Duplicate Expense] Allow bulk duplication.  #84657's author because it was the triggering PR
• The bug is marked "new feature, doesn't exist in prod" — bulk duplication is the new feature introduced in [Duplicate Expense] Allow bulk duplication.  #84657
• The issue reproduces on staging only, which aligns with [Duplicate Expense] Allow bulk duplication.  #84657 being merged on 2026-04-09 and not yet in production

Verification

PR #84657 modifies the following files directly relevant to the bug:

• src/components/MoneyReportHeader.tsx — added conditional rendering of BulkDuplicateHandler component when isDuplicateOptionVisible is true
• src/hooks/useSelectedTransactionsActions.ts — added isDuplicateOptionVisible computed from shouldShowBulkDuplicateOption
• src/hooks/useSearchBulkActions.ts — introduced the shouldShowBulkDuplicateOption function
• src/hooks/useBulkDuplicateAction.ts — new hook handling bulk duplication
• src/components/Search/BulkDuplicateHandler.tsx — new invisible component for bulk duplicate subscriptions
• src/libs/actions/IOU/Duplicate.ts — added bulkDuplicateExpenses function

All of these files are confirmed to be in the affected code path.

Root Cause

The shouldShowBulkDuplicateOption function in useSearchBulkActions.ts does not check whether the parent expense report is in a paid/reimbursed state. As a result, when a user selects distance expenses on a paid report, isDuplicateOptionVisible evaluates to true.

This causes the BulkDuplicateHandler component to mount inside MoneyReportHeader.tsx. When the user triggers the bulk duplication and then navigates back (clearing the selection), there is a brief window during which the newly duplicated transactions (or the original transactions) may have DUPLICATED_TRANSACTION violations registered before the component fully unmounts and state settles. During this transition, getReportPrimaryAction evaluates the violation data and temporarily returns REVIEW_DUPLICATES, causing the "Potential duplicate" banner to flash in the expense header.

The fix should add a check in shouldShowBulkDuplicateOption to return false when isReportReimbursed (i.e., stateNum === APPROVED && statusNum === REIMBURSED), mirroring the guard that already exists for the canHoldTransactions check in useSelectedTransactionsActions.ts (line 274-276).

[MelvinBot]

Proposal

What is the root cause of that problem?

useMoneyReportHeaderStatusBar computes hasDuplicates via hasDuplicateTransactions() without checking whether the report is already settled/paid. The underlying isDuplicate() only checks whether a DUPLICATED_TRANSACTION violation exists and isn't dismissed — it has no awareness of report payment status.

When a report is paid, payMoneyRequest optimistically clears transaction violations, but the server response re-populates them (violations persist server-side after payment). This causes the "Potential duplicate" banner to briefly flash in the header before a subsequent re-render hides it.

What changes do you think we should make in order to solve the problem?

In useMoneyReportHeaderStatusBar.ts line 79, guard hasDuplicates with an isSettled check so the duplicates banner is never shown for paid/reimbursed reports:

const hasDuplicates = !isSettled(moneyRequestReport) && hasDuplicateTransactions(...)

Import isSettled from ReportUtils. This is the minimal fix — paid reports should never show the duplicate banner regardless of what violation data the server returns.

What alternative solutions did you explore? (Optional)

An alternative would be to add the guard inside getStatusBarType() at line 107, but guarding at the hasDuplicates computation is cleaner since it also prevents shouldShowStatusBar from being true due to stale duplicate violations on settled reports.

Another option would be fixing the server to strip DUPLICATED_TRANSACTION violations after payment, but that's a larger change and the client should still be resilient to this.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.