Skip to content

⚒️ Miscellaneous Suggestions #37

@FRFlo

Description

@FRFlo

Is there an existing issue for this?

  • I have searched the existing issues

Proposal

  • Factor out any “Exchange” placeholder code if it is not implemented.

    • The Program references an Exchange(client) type that presumably lives in another file or is incomplete. If it is not needed, removing or finishing that code will reduce confusion.
  • Implement a test suite.

    • While not strictly shown here, writing unit or integration tests (especially for Local vs. SFTP clients) will catch regressions in file operations, filtering, error paths, and cross-platform differences.
  • Consistent library usage for path manipulations.

    • While Path.Combine is correct, you might prefer Path.Join or other modern .NET path methods in .NET 6+ or 7+, especially if you adopt some new features in .NET 8.

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions