Skip to content

[Solution] FancyNames option is dead code #445

Description

@ChrisonSimtian

Problem

The FancyNames option for the [Solution] strongly-typed accessor does nothing, two ways: SolutionAttribute exposes no FancyNames property (only List/GenerateProjects), so [Solution(FancyNames = true)] won't compile; and even when forced on, the emitter strips the fancy ٠ separator so output is identical to the default. Surfaced in #442.

Outcome

FancyNames is either a working, settable option or removed entirely — no dangling reads left in the emitter, generator, or console.

Acceptance criteria

  • [Solution(FancyNames = true)] compiles and changes accessor names (Foo.BarFoo٠Bar), or the concept is removed across SolutionEmitter, StronglyTypedSolutionGenerator, and Fallout.Solution.Codegen.
  • A spec in Fallout.Solution.Codegen.Specs pins the chosen behaviour.

Notes

  • No-op root cause: GetEscapedName does .Replace(".", "٠") then .ReplaceRegex(@"[^A-Za-z0-9_]", "_") (ASCII-only), which deletes the ٠src/Fallout.Solution.Codegen.Emit/SolutionEmitter.cs:91.
  • Attribute missing the property: src/Fallout.Common/Attributes/SolutionAttribute.cs. Generator read: src/Fallout.SourceGenerators/StronglyTypedSolutionGenerator.cs:52.
  • Non-breaking either way.

Metadata

Metadata

Labels

bugSomething isn't workingtarget/2026Targets the 2026 calendar-version line (current). See ADR-0004.

Type

Fields

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions