Environment Variables prepended with `FALLOUT_` don't work.

[pkillboredom]

Usage Information

10.3.49

Description

Contrary to the information stated in the documentation for Parameters, the code is still looking for NUKE_.

Problem Code:

Fallout/src/Fallout.Build/Execution/ParameterService.cs

Line 192 in f57634c

GetTrimmedName(x.Key).EqualsOrdinalIgnoreCase($"NUKE{trimmedVariableName}")).ToList();

I can create a PR later to address this, but I am unsure if it should also remain compatible with NUKE_. LMK what you think.

Reproduction Steps

1. Create Build Project
2. Add a string parameter.
3. Assert in target when parameter is null.
4. export FALLOUT_MY_PARAMETER_NAME="hello"
5. Run build, reach assertion.
6. export NUKE_MY_PARAMETER_NAME="hello"
7. Run build, no assertion.

Expected Behavior

Environment variables prepended with FALLOUT_ should be used for parameters as per documentation.

Actual Behavior

See Repro.

Regression?

Kind of. Technically?

Known Workarounds

No response

Could you help with a pull-request?

Yes

[ITaluone]

Ok.. on your go

[IT-VBFK]

I can create a PR later to address this, but I am unsure if it should also remain compatible with NUKE_

Yes, of course. We are currently in the transition phase

[ChrisonSimtian]

Hi @pkillboredom , happy for you to contribute and fix this via a pr :-) As for your question: i would say let's move forward and drop the NUKE_ (pun intended) if it complicates things too much. we can always slot breaking changes into the next major release