making callable default to null

Author: catherineGCD

src/UseCases/PushDeletedToCyclopsUseCase.php

@@ -19,14 +19,18 @@ public function __construct(CyclopsService $cyclopsService)
         $this->cyclopsService = $cyclopsService;
     }
 
-    public function execute(CyclopsCustomerListEntity $list, callable $onCustomerDeleted)
+    public function execute(CyclopsCustomerListEntity $list, callable $onCustomerDeleted = null)
     {
         foreach ($list->items as $item) {
             try {
                 $this->cyclopsService->deleteCustomer($item->identity);
-                $onCustomerDeleted($item);
-	        } catch (CustomerNotFoundException $exception) {
-		        $onCustomerDeleted($item);
+                if ($onCustomerDeleted !== null) {
+                    $onCustomerDeleted($item);
+                }
+            } catch (CustomerNotFoundException $exception) {
+                if ($onCustomerDeleted !== null) {
+                    $onCustomerDeleted($item);
+                }
             } catch (CyclopsException $exception) {
             }
         }

src/UseCases/PushStaleToCyclopsUseCase.php

@@ -18,19 +18,23 @@ public function __construct(CyclopsService $cyclopsService)
         $this->cyclopsService = $cyclopsService;
     }
 
-    public function execute(CyclopsCustomerListEntity $list, callable $onCustomerCreated)
+    public function execute(CyclopsCustomerListEntity $list, callable $onCustomerCreated = null)
     {
         foreach ($list->items as $item) {
             try {
                 $this->cyclopsService->setBrandOptInStatus($item);
 
-                $onCustomerCreated($item);
+                if ($onCustomerCreated !== null) {
+                    $onCustomerCreated($item);
+                }
             } catch (CustomerNotFoundException $exception) {
                 $customer = $this->cyclopsService->loadCustomer($item->identity);
                 $customer->brandOptIn = $item->brandOptIn;
                 $this->cyclopsService->setBrandOptInStatus($customer);
 
-                $onCustomerCreated($customer);
+                if ($onCustomerCreated !== null) {
+                    $onCustomerCreated($customer);
+                }
             }
         }
     }

tests/unit/UseCases/PushDeletedToCyclopsUseCaseTest.php

@@ -43,7 +43,7 @@ public function testDeletedPushedToCyclops()
         $list->items = [$createEntity('test@test.com'), $createEntity('test@testtest.com')];
 
         $useCase = new PushDeletedToCyclopsUseCase($service);
-        $useCase->execute($list, function() {});
+        $useCase->execute($list);
         verify($deletedCount)->equals(2);
     }
 }

tests/unit/UseCases/PushStaleToCyclopsUseCaseTest.php

@@ -40,7 +40,7 @@ public function testStalePushedToCyclops()
         $list->items = [$createEntity('test@test.com'), $createEntity('test@testtest.com')];
 
         $useCase = new PushStaleToCyclopsUseCase($service);
-        $useCase->execute($list, function () {});
+        $useCase->execute($list);
         verify($staleCount)->equals(2);
     }
 }