From c978957b6e43d0e73dd9cff58042ff0a5ef0d0b5 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Mon, 25 Nov 2024 21:39:36 +0100
Subject: [PATCH 1/5] Offload inline-css to file

---
 public/assets/css/geant.css     | 6 ++++++
 themes/tnc/default/_header.twig | 6 +-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/public/assets/css/geant.css b/public/assets/css/geant.css
index 5761e28..559ed42 100644
--- a/public/assets/css/geant.css
+++ b/public/assets/css/geant.css
@@ -4,6 +4,12 @@ body {
   background-color: #ddd;
 }
 
+#header {
+    background-repeat: no-repeat;
+    background-size: cover;
+    height: 14rem;
+}
+
 div.wrap {
     margin-left: 2%;
     margin-right: 2%;
diff --git a/themes/tnc/default/_header.twig b/themes/tnc/default/_header.twig
index 55b895e..7afceae 100644
--- a/themes/tnc/default/_header.twig
+++ b/themes/tnc/default/_header.twig
@@ -2,11 +2,7 @@
 <link rel="stylesheet" href="{{ asset('css/geant.css', 'geant') }}">
 {% endblock %}
 {% set hideLanguageBar = true %}
-<header id="header" style="
-    background:url('{{ asset('gfx/' ~ tnc_pic , 'geant') }}');
-    background-repeat: no-repeat;
-      background-size: cover;
-      height: 14rem;">
+<header id="header">
   <div class="wrap">
 <img id="geant" src="{{ asset('gfx/geant-logo-white.svg', 'geant') }}" alt="GÉANT logo"/>
 <p class="credits">

From c128a0b2e5abeab4fca85c366babf1f48ae550fa Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Mon, 25 Nov 2024 21:40:59 +0100
Subject: [PATCH 2/5] Fix identation

---
 themes/tnc/default/_header.twig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/themes/tnc/default/_header.twig b/themes/tnc/default/_header.twig
index 7afceae..ec55be3 100644
--- a/themes/tnc/default/_header.twig
+++ b/themes/tnc/default/_header.twig
@@ -4,10 +4,10 @@
 {% set hideLanguageBar = true %}
 <header id="header">
   <div class="wrap">
-<img id="geant" src="{{ asset('gfx/geant-logo-white.svg', 'geant') }}" alt="GÉANT logo"/>
-<p class="credits">
-    Picture from <a title="Go to {% if 'web.archive.org' in tnc_url %}an archived copy of {% endif %}the {{ tnc_name }} website" href="{{ tnc_url }}">{{ tnc_name }}</a> in {{ tnc_location|e }} &copy; {{ copyright|e }}
-</p>
+    <img id="geant" src="{{ asset('gfx/geant-logo-white.svg', 'geant') }}" alt="GÉANT logo"/>
+    <p class="credits">
+        Picture from <a title="Go to {% if 'web.archive.org' in tnc_url %}an archived copy of {% endif %}the {{ tnc_name }} website" href="{{ tnc_url }}">{{ tnc_name }}</a> in {{ tnc_location|e }} &copy; {{ copyright|e }}
+    </p>
     {% if not hideLanguageBar %}
     <div class="menuspace">
       <a href="" id="menuLink" class="menu-link hide-for-large">

From a2343066f9337699b7ab4eb9f5e8857f0ab8ee4f Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Mon, 25 Nov 2024 21:42:05 +0100
Subject: [PATCH 3/5] Remove closing tag on img

---
 themes/tnc/default/_header.twig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/themes/tnc/default/_header.twig b/themes/tnc/default/_header.twig
index ec55be3..29744a0 100644
--- a/themes/tnc/default/_header.twig
+++ b/themes/tnc/default/_header.twig
@@ -4,7 +4,7 @@
 {% set hideLanguageBar = true %}
 <header id="header">
   <div class="wrap">
-    <img id="geant" src="{{ asset('gfx/geant-logo-white.svg', 'geant') }}" alt="GÉANT logo"/>
+    <img id="geant" src="{{ asset('gfx/geant-logo-white.svg', 'geant') }}" alt="GÉANT logo">
     <p class="credits">
         Picture from <a title="Go to {% if 'web.archive.org' in tnc_url %}an archived copy of {% endif %}the {{ tnc_name }} website" href="{{ tnc_url }}">{{ tnc_name }}</a> in {{ tnc_location|e }} &copy; {{ copyright|e }}
     </p>

From e25a5bde9e9eed3891a896de9f01dbedf5c5b5f7 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Mon, 25 Nov 2024 21:59:00 +0100
Subject: [PATCH 4/5] Use js to set dynamic background

---
 public/assets/js/geant.js       | 6 ++++++
 themes/tnc/default/_header.twig | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 public/assets/js/geant.js

diff --git a/public/assets/js/geant.js b/public/assets/js/geant.js
new file mode 100644
index 0000000..909d485
--- /dev/null
+++ b/public/assets/js/geant.js
@@ -0,0 +1,6 @@
+ready(function () {
+    window.onpageshow = function () {
+        var header = document.getElementById("header");
+        header.style.backgroundImage = header.getAttribute("data-img");
+    }
+});
diff --git a/themes/tnc/default/_header.twig b/themes/tnc/default/_header.twig
index 29744a0..aba67c5 100644
--- a/themes/tnc/default/_header.twig
+++ b/themes/tnc/default/_header.twig
@@ -2,7 +2,7 @@
 <link rel="stylesheet" href="{{ asset('css/geant.css', 'geant') }}">
 {% endblock %}
 {% set hideLanguageBar = true %}
-<header id="header">
+<header id="header" data-img="url('/public/assets/gfx/{{ tng_img }}')">
   <div class="wrap">
     <img id="geant" src="{{ asset('gfx/geant-logo-white.svg', 'geant') }}" alt="GÉANT logo">
     <p class="credits">

From e036ca726de5788e8c3de8dff77614a5c294b94f Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Mon, 25 Nov 2024 22:00:03 +0100
Subject: [PATCH 5/5] Remove unused var

---
 src/ThemeTncController.php | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/ThemeTncController.php b/src/ThemeTncController.php
index ec6da01..995b824 100644
--- a/src/ThemeTncController.php
+++ b/src/ThemeTncController.php
@@ -22,7 +22,6 @@ public function display(array &$data): void
         $tncs = $moduleConfig->getArray('tncs');
         $tnc_pics = $moduleConfig->getArray('tnc_pics');
 
-        $tnc_pics_dir = Module::getModuleDir('geant') . '/public/assets/gfx';
         $pic = $tnc_pics[rand(0,count($tnc_pics)-1)];
 
         $tnc_year = substr($pic['filename'], 3, 4);
@@ -39,5 +38,4 @@ public function display(array &$data): void
         $data['copyright'] = $pic['copyright'];
         $data['original_url'] = $pic['original_url'];
     }
-
 }