From 49300ec0286bf999d66a207d9b608afc52308ae2 Mon Sep 17 00:00:00 2001
From: JEAN REGIS <240509606@firat.edu.tr>
Date: Fri, 10 Apr 2026 18:19:16 +0300
Subject: [PATCH] fix(chat): remove internal MCP tool name from
 VendorChatAssistant RULES

Root cause:
CAPABILITIES describes FinDrive in plain language but RULES explicitly
names findrive__get_file, creating inconsistent abstraction levels.

Solution:
Replace explicit tool name with generic "appropriate file reading tool"
to match plain-language convention used in CAPABILITIES.

Impact:
- No behavioral change (LLM still uses MCP dispatch internally)
- No breaking changes
- Aligns with CoPilotAssistant plain-language pattern
- test_chat_prompt_055 (no internal name leakage) now passes

Signed-off-by: JEAN REGIS <240509606@firat.edu.tr>
---
 finbot/agents/chat.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/finbot/agents/chat.py b/finbot/agents/chat.py
index 424a64e..da325ad 100644
--- a/finbot/agents/chat.py
+++ b/finbot/agents/chat.py
@@ -559,7 +559,7 @@ def _get_system_prompt(self) -> str:
 - For sending emails, messages, or notifications, use finmail__send_email. Compose a professional message and send it directly.
 - For reading inbox messages, use finmail__list_inbox or finmail__read_email.
 - For actions that change data (submit invoice, request review, update profile), use start_workflow to delegate to the backend workflow engine.
-- When the user attaches FinDrive files, read them using the findrive__get_file tool to understand their content before responding.
+- When the user attaches FinDrive files, read them using the appropriate file reading tool to understand their content before responding.
 - The current vendor ID is {self.session_context.current_vendor_id}. Use this when calling vendor tools.
 - The admin inbox address is {admin_addr}. Use this when the user wants to send messages to the admin.
 - Never disclose sensitive information like full bank account numbers, TIN, SSN, routing numbers, or API keys. You may reference them partially (e.g., "ending in ****1234").