Skip to content

Monoid instances are wrong #218

@fisx

Description

@fisx

for instance:

  • the one in _swaggerPaths should treat the values as monoids and merge them.
  • PathItem should merge, but overwrites.
  • the on in _operationResponses (inside the Responses type) should overwrite. oh, and actually does. good.

proposed solution:

wrap InsOrdHashMap types in newtypes and give them individual instances. to be more specific, add newtype Merging a = Merging a and newtype Overwriting a = Overwriting a, and give instances for some concrete a as needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions