From 7aaa842dc890671ec5c4e36ac2d3cc3fcd9baeaa Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 02:29:57 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- src/main/java/com/perye/dokit/utils/FileUtil.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/perye/dokit/utils/FileUtil.java b/src/main/java/com/perye/dokit/utils/FileUtil.java index 289f00f..c7387b9 100644 --- a/src/main/java/com/perye/dokit/utils/FileUtil.java +++ b/src/main/java/com/perye/dokit/utils/FileUtil.java @@ -15,6 +15,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import java.io.*; +import java.nio.file.Files; import java.security.MessageDigest; import java.text.DecimalFormat; import java.text.SimpleDateFormat; @@ -71,7 +72,7 @@ public static File toFile(MultipartFile multipartFile) { File file = null; try { // 用uuid作为文件名，防止生成的临时文件重复 - file = File.createTempFile(IdUtil.simpleUUID(), prefix); + file = Files.createTempFile(IdUtil.simpleUUID(),prefix).toFile(); // MultipartFile to File multipartFile.transferTo(file); } catch (IOException e) {