The send_notification_email function uses a variable reviewers_notified to decide the content of the template submission_status.html, i.e. whether the notification is associated with a new upload. It's assumed that the Uploader will click "Notify Participants" when a new upload is made, then reviewers_notified will be set to True. However, if the Uploader does not take this action (so reviewers_notified is False), and the Reviewer clicks "Notify Participants" first, then the contents of the email will be wrong. If the participant initiating the notification email only has Reviewer permissions, the code should not include the email contents indicating that they made the upload.
The
send_notification_emailfunction uses a variablereviewers_notifiedto decide the content of the templatesubmission_status.html, i.e. whether the notification is associated with a new upload. It's assumed that the Uploader will click "Notify Participants" when a new upload is made, thenreviewers_notifiedwill be set toTrue. However, if the Uploader does not take this action (soreviewers_notifiedis False), and the Reviewer clicks "Notify Participants" first, then the contents of the email will be wrong. If the participant initiating the notification email only has Reviewer permissions, the code should not include the email contents indicating that they made the upload.