From aff926b6156e1e674dd2368fe1775d6d350f08ed Mon Sep 17 00:00:00 2001 From: Kanishk Sachdev Date: Thu, 24 Jul 2025 23:54:08 +0530 Subject: [PATCH] changing and reading perms --- src/modules/email/email.controller.ts | 2 +- src/modules/finance/finance.controller.ts | 4 ++-- src/modules/inventory/inventory.controller.ts | 6 +++--- src/modules/judging/judging.controller.ts | 2 +- src/modules/organizer/organizer.controller.ts | 7 +++++-- 5 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/modules/email/email.controller.ts b/src/modules/email/email.controller.ts index 6bcbb887..b616a979 100644 --- a/src/modules/email/email.controller.ts +++ b/src/modules/email/email.controller.ts @@ -17,7 +17,7 @@ export class EmailController { constructor(private readonly namecheap: NamecheapEmailForwardingService) {} @Get("/forwarding") - //@Roles(Role.EXEC) + @Roles(Role.TEAM) @ApiDoc({ summary: "Get all email forwarding settings for hackpsu.org", auth: Role.EXEC, diff --git a/src/modules/finance/finance.controller.ts b/src/modules/finance/finance.controller.ts index 450d31cf..a38bd7fd 100644 --- a/src/modules/finance/finance.controller.ts +++ b/src/modules/finance/finance.controller.ts @@ -85,7 +85,7 @@ export class FinanceController { ) {} @Get("/") - @Roles(Role.EXEC) + @Roles(Role.TEAM) @ApiDoc({ summary: "Get all Reimbursements", response: { @@ -98,7 +98,7 @@ export class FinanceController { } @Get(":id") - @Roles(Role.EXEC) + @Roles(Role.TEAM) @ApiDoc({ summary: "Get a Reimbursement", params: [ diff --git a/src/modules/inventory/inventory.controller.ts b/src/modules/inventory/inventory.controller.ts index 346015fb..6bbcb416 100644 --- a/src/modules/inventory/inventory.controller.ts +++ b/src/modules/inventory/inventory.controller.ts @@ -92,7 +92,7 @@ export class InventoryController { // ===== CATEGORIES ===== @Get("categories") - @Roles(Role.TEAM, Role.EXEC, Role.TECH) + @Roles(Role.TEAM) @ApiDoc({ summary: "List all inventory categories", response: { ok: { type: InventoryCategoryEntity, isArray: true } }, @@ -134,7 +134,7 @@ export class InventoryController { // ===== ITEMS ===== @Get("items") - @Roles(Role.TEAM, Role.EXEC, Role.TECH) + @Roles(Role.TEAM) @ApiDoc({ summary: "List all inventory items", response: { ok: { type: InventoryItemEntity, isArray: true } }, @@ -182,7 +182,7 @@ export class InventoryController { // ===== MOVEMENTS ===== @Get("movements") - @Roles(Role.TEAM, Role.EXEC, Role.TECH) + @Roles(Role.TEAM) @ApiDoc({ summary: "List all inventory movements", response: { ok: { type: InventoryMovementEntity, isArray: true } }, diff --git a/src/modules/judging/judging.controller.ts b/src/modules/judging/judging.controller.ts index cdf84e8d..2fe8cb88 100644 --- a/src/modules/judging/judging.controller.ts +++ b/src/modules/judging/judging.controller.ts @@ -153,7 +153,7 @@ export class JudgingController { } @Post("/assign") - //@Roles(Role.EXEC) + @Roles(Role.EXEC) async assignJudging( @Body( new ValidationPipe({ diff --git a/src/modules/organizer/organizer.controller.ts b/src/modules/organizer/organizer.controller.ts index dd8712d2..74f573a2 100644 --- a/src/modules/organizer/organizer.controller.ts +++ b/src/modules/organizer/organizer.controller.ts @@ -88,7 +88,7 @@ export class OrganizerController { ) {} @Get("/") - @Roles(Role.EXEC) + @Roles(Role.TEAM) @ApiDoc({ summary: "Get All Organizers", response: { @@ -188,11 +188,14 @@ export class OrganizerController { noContent: true, }, }) - @Roles(Role.EXEC) + @Roles(Role.TECH) async resendAllVerificationEmails() { const allOrganizers = await this.organizerRepo.findAll().exec(); for (const organizer of allOrganizers) { + if (!organizer.isActive) { + continue; + } try { const passwordResetLink = await this.auth.generatePasswordResetLink( organizer.email,