Merge pull request #226 from GrandMoff100/copilot/fix-error-responses-bug

Fix optional translation fields in websocket Error model

Author: GrandMoff100

homeassistant_api/models/websocket.py

@@ -45,9 +45,9 @@ class PingResponse(BaseModel):
 class Error(BaseModel):
     code: str
     message: str
-    translation_key: str
-    translation_placeholders: dict[str, str]
-    translation_domain: str
+    translation_key: Optional[str] = None
+    translation_placeholders: Optional[dict[str, str]] = None
+    translation_domain: Optional[str] = None
 
 
 class ErrorResponse(BaseModel):

tests/test_errors.py

@@ -23,6 +23,7 @@
     UnauthorizedError,
     UnexpectedStatusCodeError,
 )
+from homeassistant_api.models.websocket import Error
 from homeassistant_api.processing import Processing
 from homeassistant_api.utils import prepare_entity_id
 from homeassistant_api.websocket import WebsocketClient
@@ -220,3 +221,12 @@ def test_exception_unexpected_status_code() -> None:
 def test_unkown_scheme() -> None:
     with pytest.raises(ValueError):
         Client("ftp://example.com", "token")
+
+
+def test_error_model_without_optional_fields() -> None:
+    """Tests that Error model accepts responses missing optional translation fields."""
+    error = Error(code="invalid_format", message="required key not provided")
+    assert error.code == "invalid_format"
+    assert error.translation_key is None
+    assert error.translation_placeholders is None
+    assert error.translation_domain is None