Skip to content

Commit 209d7aa

Browse files
HumanBean17claude
andauthored
Improve plan skill with no-placeholders, self-review, and execution handoff (#280)
Adopt three patterns from superpowers writing-plans skill: explicit no-placeholder rule with DEFERRED escape hatch, four-step self-review checklist (coverage, placeholders, consistency, deps), and execution handoff offering subagent/inline/manual modes. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 737bbd5 commit 209d7aa

1 file changed

Lines changed: 36 additions & 3 deletions

File tree

  • .agents/skills/plan-project-scope

.agents/skills/plan-project-scope/SKILL.md

Lines changed: 36 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,33 @@ Landing order: **X1 -> X2 -> X3**.
126126

127127
- Prefer concrete, testable statements over high-level intentions.
128128
- Keep PR scopes independent when possible; state landing order explicitly.
129-
- Name tests exactly when feasible; avoid vague "add tests".
129+
- Name tests exactly when feasible; avoid vague add tests.
130130
- Call out ontology bump and re-index impact for schema/enrichment changes.
131-
- Keep "Out of scope" strict; use it to prevent scope creep during implementation.
131+
- Keep Out of scope strict; use it to prevent scope creep during implementation.
132132
- Treat **Areas of concern** as **heads-up text for reviewers** (coupling, regression risk, semantic hotspots). Do **not** phrase it as “only these modules” — honest implementation may touch adjacent files; when that happens, update the **File-by-file changes** list and **Out of scope** so the contract stays clear.
133133
- Do not add compatibility shims unless explicitly requested.
134134

135+
## No placeholders
136+
137+
Every section must contain the actual detail an agent or reviewer needs. These are **plan failures** — never write them:
138+
- “TBD”, “TODO”, “implement later”, “fill in details”
139+
- “Add appropriate error handling” / “add validation” / “handle edge cases” (without specifics)
140+
- “Write tests for the above” (without naming test cases)
141+
- “Similar to PR-X1” (repeat the detail — the implementer may read PRs out of order)
142+
- File-by-file changes that describe *what* to do without enough context for *how*
143+
- References to functions, types, or schemas not defined in any PR section
144+
145+
When a decision is genuinely deferred, label it explicitly: `**DEFERRED:** <what> — will be resolved in <which PR> because <why>.`
146+
147+
## Self-review
148+
149+
After drafting the complete plan, run these checks before finalizing:
150+
151+
1. **Spec coverage:** Skim each requirement from the proposal. Can you point to a PR section that implements it? Add tasks for any gaps.
152+
2. **Placeholder scan:** Search the plan for the anti-patterns listed in “No placeholders” above. Fix them.
153+
3. **Consistency check:** Do function names, type signatures, schema versions, and file paths used in later PRs match what earlier PRs define? A function called `clearLayers()` in PR-X1 but `clearFullLayers()` in PR-X3 is a plan bug.
154+
4. **Dependency order:** Does the landing order actually satisfy all cross-PR dependencies stated in the overview table?
155+
135156
## Per-PR execution prompt option
136157

137158
If the user wants agent-ready per-PR prompts, add a companion file:
@@ -151,12 +172,24 @@ Use **any** completed **`plans/completed/AGENT-PROMPTS-*.md`** as the structural
151172
- Active plan files live in `plans/active/` as `PLAN-<TOPIC>.md` (uppercase topic).
152173
- Move completed plans to `plans/completed/` after full rollout lands.
153174

175+
## Execution handoff
176+
177+
After saving the plan, offer the user an execution choice:
178+
179+
1. **Subagent-driven** — dispatch a fresh subagent per PR (via `superpowers:subagent-driven-development`), review between PRs, fast iteration. Best for multi-PR plans.
180+
2. **Inline execution** — execute PRs in this session (via `superpowers:executing-plans`), batch execution with checkpoints. Best for single-PR plans or when context continuity matters.
181+
3. **Manual handoff** — save the plan and AGENT-PROMPTS file for later execution. The implementer picks up from the written artifacts.
182+
183+
If the user picks option 1 or 2, invoke the corresponding superpowers skill before starting execution.
184+
154185
## Final checklist
155186

156187
- [ ] Plan has status, goal, principles, PR breakdown, risks, out-of-scope, done definition
157-
- [ ] Every PR section has file-level scope and tests
188+
- [ ] Every PR section has file-level scope and named tests
189+
- [ ] No placeholders — every section has concrete detail, no TBD/TODO/vague directives
158190
- [ ] Ontology/reindex implications are explicit when relevant
159191
- [ ] Implementation order is explicit and dependency-safe
192+
- [ ] Cross-PR names/types/paths are consistent (self-review passed)
160193
- [ ] Plan is execution-ready without re-deriving design
161194

162195
## Additional resources

0 commit comments

Comments
 (0)