Commit be000ae
committed
fix(cli): drop unimplemented --brief/--fields/--count/--exists; fix install --verbose mock (final review)
- Remove four unimplemented flags (--brief, --fields, --count, --exists) from the
common parent parser in jrag.py. These flags were registered but never read by
any handler, violating the "inapplicable flags never silently ignored" principle.
- Remove references to these flags from skills/explore-codebase-cli/SKILL.md and
agents/explorer-rag-cli.md documentation.
- Fix test_cmd_install_forwards_verbose_flag mock signature to accept surface="mcp"
(matching run_install's new signature from PR-5), and assert the default forwarding.
- Run sync_agent_artifacts.py to propagate documentation changes to install_data.
Fixes #END_OF_PLAN_FULL_SUITE1 parent ca7a73d commit be000ae
6 files changed
Lines changed: 3 additions & 32 deletions
File tree
- agents
- java_codebase_rag
- install_data
- agents
- skills/explore-codebase-cli
- skills/explore-codebase-cli
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | 59 | | |
64 | 60 | | |
65 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | 59 | | |
64 | 60 | | |
65 | 61 | | |
| |||
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | 65 | | |
70 | 66 | | |
71 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | 157 | | |
173 | 158 | | |
174 | 159 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | 65 | | |
70 | 66 | | |
71 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1511 | 1511 | | |
1512 | 1512 | | |
1513 | 1513 | | |
1514 | | - | |
| 1514 | + | |
1515 | 1515 | | |
1516 | 1516 | | |
1517 | 1517 | | |
| 1518 | + | |
1518 | 1519 | | |
1519 | 1520 | | |
1520 | 1521 | | |
| |||
1525 | 1526 | | |
1526 | 1527 | | |
1527 | 1528 | | |
| 1529 | + | |
1528 | 1530 | | |
1529 | 1531 | | |
1530 | 1532 | | |
| |||
0 commit comments