-
Notifications
You must be signed in to change notification settings - Fork 3
Description
For adding the recording of gradient descent information into each EngiBench problem, I wanted to propose a means for this that consistent across all problems. Specifically, I was thinking that we could add an addition field to the OptiStep data class (specifically a npt.NDArray), that contains a gradient descent step for an optimization routine. I would argue that this is an appropriate place, as the optimize function of all problems is designed (at least in the parent Problem class) to return the final design and a list of OptiStep objects already. Furthermore, the list of OptiStep objects is defined as containing the optimization history, which I think fits the bill. Of course, if there is a better way to do this I am happy to implement it as well. Once the format is agreed upon, my plan is to create a new branch for each problem, add the functionality, and submit a pull request.