Skip to content

[BUG] Unable to get lyrics from Uploads #168

@wont-stream

Description

@wont-stream

Prerequisites

Please check the following before continuing:

  • I have searched for existing issues, including closed issues to ensure this is not a duplicate.
  • This is a issue for the Luna Client and not a Plugin
  • I am running the latest Luna Client version (See latest release)

Environment

  • OS: Windows
  • Client Version: 1.14.0-beta

Description

When attempting to get lyrics from @luna/lib, if the user is playing an uploaded track, it will gracefully fail (just returned undefined as expected)
This can be avoided by using the TIDAL's new OpenAPI which supports the upload tracks
(not 100% sure if it works for nonuploaded tracks, but I would sure hope it did)
https://tidal-music.github.io/tidal-api-reference/#/tracks/get_tracks__id_

Steps to Reproduce

Steps to reproduce the behavior:

  1. Play a user uploaded track
  2. Open console
await ((await luna.lib.MediaItem.fromPlaybackContext())).lyrics()

Expected Behavior

If playing an upload track, use the openapi instead of the legacy api to fetch lyrics

Actual Behavior

Returns undefined

Additional Context

desktop.tidal.com v1 api: https://desktop.tidal.com/v1/tracks/519154664/lyrics?countryCode=US&deviceType=DESKTOP&locale=en-us
openapi.tidal.com v2 api: https://openapi.tidal.com/v2/tracks/519154664?countryCode=US&include=lyrics

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions