ops(flake-review): only run when needed and allow manual trigger#167
Conversation
|
@Inrixia seems like i already had it accidentally set it up in a way that its really easy to just add PR URL as custom input :D |
|
Nice, ima let it run since the other branch couldn't and then merge. Thanks again for this! |
There was a problem hiding this comment.
Pull request overview
This PR narrows when the Flake Review workflow runs on pull requests and adds a manual dispatch path for reviewing a specified PR URL.
Changes:
- Adds pull request
pathsfilters for flake/Nix/package-related files. - Adds
workflow_dispatchwith a requiredpr-urlinput. - Updates the reusable flake-review workflow and
flake-review-reffrom0.1.2to0.2.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Good bot, @ojsef39 boop see comments |
|
@ojsef39 your workflow timed out btw |
its just waiting for the previous pipeline to be cancelled, the post-x jobs arent instantly cancelled, so it will only start the next pipeline after the caching is done for the previous one. a bit confusing especially since it just wont show a pipeline and only show that info when you click on the pipeline itself :D see the orange text: https://github.com/Inrixia/TidaLuna/actions/runs/25850357182 |
|
Ah yea just realized once I saw you'd force pushed. Ig we will see if it's any faster now that it can take advantage of the cache :) |
Yeeeah i hope so as well :) Probably takes a while now since its first time pushing to this repos cache xD |
|
Ping me once it's run again :) |
|
oh well now it actually died, i love github sometimes xD |
|
ig the concurrency group is too complicated now
which is the default should do as well |
|
@Inrixia running again :) |
|
ahhhh shiiiiiiit, i only now noticed that my previous comment about fork PRs does still apply. Usually PRs are from forks… mhmmm i have to think about how to solve this |
|
okay i found a way to make this work, i tried this with a fork of flake-review and creating a PR to it so should work now as soon as its merged :) now the commenting pipeline gets triggered by github when the build is done, which means the commenting pipeline runs from this repo and thus can comment |
No description provided.