Skip to content

ops(flake-review): only run when needed and allow manual trigger#167

Merged
Inrixia merged 1 commit into
Inrixia:masterfrom
ojsef39:master
May 14, 2026
Merged

ops(flake-review): only run when needed and allow manual trigger#167
Inrixia merged 1 commit into
Inrixia:masterfrom
ojsef39:master

Conversation

@ojsef39

@ojsef39 ojsef39 commented May 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 14, 2026 08:26
@ojsef39

ojsef39 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

@Inrixia seems like i already had it accidentally set it up in a way that its really easy to just add PR URL as custom input :D

@Inrixia

Inrixia commented May 14, 2026

Copy link
Copy Markdown
Owner

Nice, ima let it run since the other branch couldn't and then merge. Thanks again for this!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR narrows when the Flake Review workflow runs on pull requests and adds a manual dispatch path for reviewing a specified PR URL.

Changes:

  • Adds pull request paths filters for flake/Nix/package-related files.
  • Adds workflow_dispatch with a required pr-url input.
  • Updates the reusable flake-review workflow and flake-review-ref from 0.1.2 to 0.2.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/flake-review.yml Outdated
Comment thread .github/workflows/flake-review.yml Outdated
@Inrixia

Inrixia commented May 14, 2026

Copy link
Copy Markdown
Owner

Good bot, @ojsef39 boop see comments

@Inrixia

Inrixia commented May 14, 2026

Copy link
Copy Markdown
Owner

@ojsef39 your workflow timed out btw

@ojsef39

ojsef39 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

@ojsef39 your workflow timed out btw

its just waiting for the previous pipeline to be cancelled, the post-x jobs arent instantly cancelled, so it will only start the next pipeline after the caching is done for the previous one. a bit confusing especially since it just wont show a pipeline and only show that info when you click on the pipeline itself :D

see the orange text: https://github.com/Inrixia/TidaLuna/actions/runs/25850357182

@Inrixia

Inrixia commented May 14, 2026

Copy link
Copy Markdown
Owner

Ah yea just realized once I saw you'd force pushed. Ig we will see if it's any faster now that it can take advantage of the cache :)

@ojsef39

ojsef39 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Ah yea just realized once I saw you'd force pushed. Ig we will see if it's any faster now that it can take advantage of the cache :)

Yeeeah i hope so as well :)

Probably takes a while now since its first time pushing to this repos cache xD

@Inrixia

Inrixia commented May 14, 2026

Copy link
Copy Markdown
Owner

Ping me once it's run again :)

@ojsef39

ojsef39 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

oh well now it actually died, i love github sometimes xD

Copilot AI review requested due to automatic review settings May 14, 2026 08:42
@ojsef39

ojsef39 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

ig the concurrency group is too complicated now

{workflow}-{ref}

which is the default should do as well

@ojsef39

ojsef39 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

@Inrixia running again :)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ojsef39

ojsef39 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

ahhhh shiiiiiiit, i only now noticed that my previous comment about fork PRs does still apply.

Usually PRs are from forks… mhmmm i have to think about how to solve this

@ojsef39

ojsef39 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

okay i found a way to make this work, i tried this with a fork of flake-review and creating a PR to it so should work now as soon as its merged :)

now the commenting pipeline gets triggered by github when the build is done, which means the commenting pipeline runs from this repo and thus can comment

@Inrixia Inrixia merged commit c805d9c into Inrixia:master May 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants