Players can bypass plot protection by using buckets on use-allowed blocks

[zombachu]

Server Implementation

Paper

Server Version

1.21.11

Describe the bug

See video

To Reproduce

1. Set a use flag that accepts blocks able to be flooded with liquid (e.g. levers)
2. While holding a filled bucket, shift-right-click on a use-flag interactable block such that it would be placed in the foldable use-flag block

Expected behaviour

Unadded players to not be able to empty liquids on a plot

Screenshots / Videos

use.flag.exploit.mov

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/7abb0398dbe14adc9b8b0358b6d60029

PlotSquared Version

7.5.13-SNAPSHOT

Checklist

• I have included a Plot debugpaste.
• I am using the newest build from https://www.spigotmc.org/resources/77506/ and the issue still persists.

Anything else?

Line:

PlotSquared/Bukkit/src/main/java/com/plotsquared/bukkit/listener/PlayerEventListener.java

Line 1426 in dd66c68

if (blockTypeWrapper.accepts(BlockTypes.AIR) || blockTypeWrapper

[dordsor21]

This is an interesting one. In this case, spigot/paper do not send block destroy/place events and the entire interaction is "handled" by PlayerBucketEmptyEvent. There's no easy way to determine if the related block is (for example) a cauldron rather than something that would be replaced... Potentially we need a separate flag for water-based interactions