Skip to content

DMC-587 [API] AI Teammate and Expert jobs needs to have preJSAction function #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IstiN wants to merge 1 commit into from
Closed

DMC-587 [API] AI Teammate and Expert jobs needs to have preJSAction function #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions dmtools-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ def versions = [
poi : '5.4.1'
]

configurations {
integrationTestImplementation.extendsFrom testImplementation
integrationTestRuntimeOnly.extendsFrom testRuntimeOnly
}

dependencies {
// Testing
testImplementation 'junit:junit:4.13.2'
Expand Down Expand Up @@ -108,6 +103,7 @@ dependencies {
// Test dependencies
testImplementation platform("org.junit:junit-bom:${versions.junit}")
testImplementation 'org.junit.jupiter:junit-jupiter'
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'

@IstiN IstiN Oct 6, 2025

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 For better readability and maintenance, it's good practice to group related dependencies together. Consider moving the junit-platform-launcher dependency next to the other JUnit dependencies.

Suggested change
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
// Test dependencies
testImplementation platform("org.junit:junit-bom:${versions.junit}")
testImplementation 'org.junit.jupiter:junit-jupiter'
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'

}

configurations.configureEach {
Expand Down Expand Up @@ -187,6 +183,11 @@ sourceSets {
}
}

configurations {
integrationTestImplementation.extendsFrom testImplementation
integrationTestRuntimeOnly.extendsFrom testRuntimeOnly
}

// Configure the processIntegrationTestResources task specifically
processIntegrationTestResources {
duplicatesStrategy = DuplicatesStrategy.INCLUDE
Expand Down
Loading