Undefined

[rpbrown3622]

When I run the module it says undefined. Is there any fix to this

Thanks

[ItsMeBrille]

Yes. There is a fix to it

[rpbrown3622]

Could you let me know what it is. I'd appreciate that

[ItsMeBrille]

Then you have to tell me what you did first

[rpbrown3622]

I just installed the modules and changed the IP address, changed the header and change bedrock to true

{
module: "MMM-MinecraftServer",
position: "bottom_center",
config: {
ip: "192.168.0.194", // server ip (required)
title: "B & D Minecraft Server", // display title
bedrock: true, // Whether its a Bedrock server
hidePlayers: false, // Hide player list
maxPlayers: 5, // Max players to show in list
hideInfo: false, // Hide bottom info (ip, version)
updateInterval: 5, // update interval in minutes
}
}

Module.register("MMM-MinecraftServer", {
defaults: {
ip: "192.168.0.194", // Minecraft server IP
title: "B & D Minecraft Server",
bedrock: true, // Whether the server is running on Bedrock edition
hidePlayers: false, // Hide player list
maxPlayers: 10, // Max players to show in list
hideInfo: false, // Hide bottom info (ip, version)
updateInterval: 5, // Default update interval (5 minutes)
},

players: [],
info: [],

start() {
Log.info(Starting module: ${this.name});
this.getPlayers();
setInterval(() => {
this.getPlayers();
}, this.config.updateInterval * 60000);
},

getStyles() {
return ["MMM-MinecraftServer.css"];
},

getPlayers() {
fetch(https://api.mcsrvstat.us/bedrock/3/${this.config.bedrock ? "/bedrock" : ""}/3/${this.config.ip})
.then((response) => response.json())
.then((data) => {
if (data.players && data.players.list) {
this.players = data.players.list;
}

    this.info.online = data.online;
    console.log(this.info.online);
    if (this.info.online) {
      this.info.motd = data.motd.html[0];
      this.info.hostname = data.hostname;
      this.info.port = data.port;
      this.info.version = data.version;
    }
    this.updateDom();
  })
  .catch((error) => {
    console.error("Error fetching Minecraft server data:", error);
  });

},

getDom() {
// Wrapper
const wrapper = document.createElement("div");
wrapper.className = "minecraft-card";

// Title
const title = document.createElement("h1");
title.className = "title";
title.innerHTML = this.config.title;
wrapper.appendChild(title);

// Server not available
if (!this.info.online) {
  const info = document.createElement("span");
  info.className = "motd";
  info.innerHTML = `Server offline`;
  wrapper.appendChild(info);
} else {
  // MOTD
  const motd = document.createElement("span");
  motd.className = "motd";
  motd.innerHTML = this.info.motd || "";
  wrapper.appendChild(motd);
}

// List players
if (!this.config.hidePlayers) {
  if(this.players[0].uuid == "00000000-0000-0000-0000-000000000000"){
    console.log("The server has turned off uuid visibility, showing default avatar");
  }
  const playerTable = document.createElement("table");
  playerTable.className = "players";

  this.players.slice(0, this.config.maxPlayers).forEach((player) => {
    const playerRow = document.createElement("tr");

    const avatarCell = document.createElement("td");
    const avatar = document.createElement("img");
    avatar.className = "player-avatar";
    avatar.src = `https://mc-heads.net/avatar/${player.uuid}/64`;
    avatarCell.appendChild(avatar);
    playerRow.appendChild(avatarCell);

    const nameCell = document.createElement("td");
    const playerName = document.createElement("span");
    playerName.className = "player-name";

    playerName.innerHTML = (player.name.length < 16) ? player.name : player.name.substring(0, 14) + "...";
    nameCell.appendChild(playerName);
    playerRow.appendChild(nameCell);

    const connectionCell = document.createElement("td");
    const connectionBars = document.createElement("div");
    connectionBars.className = "connection-bars";
    connectionCell.appendChild(connectionBars);
    playerRow.appendChild(connectionCell);

    playerTable.appendChild(playerRow);
  });
  wrapper.appendChild(playerTable);
}

// Info
if (!this.config.hideInfo) {
  const info = document.createElement("span");
  info.className = "info";
  info.innerHTML = `${this.config.ip}${this.config.bedrock ? "<br><i>Bedrock<i>" : ""}${this.info.version ? " - " + (this.info.version.length > 25 ? this.info.version.substring(0, 23) + '...' : `<i>${this.info.version}`) : ""}`;
  wrapper.appendChild(info);
}

return wrapper;

},
});

[ItsMeBrille]

@rpbrown3622 ok thanks. I see your problem. The API used to retrieve the data cannot accept a local IP address, as it cannot access the server and therefore has no knowledge of it.

I will try to submit a patch that can still display some information even when there is no server, but it will then only say something like "server offline" if the API cannot reach the server.

[rpbrown3622]

what api server should i use. if I use https://api.mcsrvstat.us/bedrock/3/xxxxxxx.d.firewalla.org (The firewalla.org is my ddns address) into a web browser I get this

{
"ip": "x.x.x.x.x",
"port": 19132,
"debug": {
"ping": false,
"query": false,
"bedrock": true,
"srv": false,
"querymismatch": false,
"ipinsrv": false,
"cnameinsrv": false,
"animatedmotd": false,
"cachehit": false,
"cachetime": 1768083896,
"cacheexpire": 1768084016,
"apiversion": 3,
"dns": {
"a": [
{
"name": "xxxxxxxxxx.d.firewalla.org",
"type": "A",
"address": "x.x.x.x.x"
}
]
},
"error": {
"query": "Failed to read from socket."
}
},
"motd": {
"raw": [
"A Minecraft Server"
],
"clean": [
"A Minecraft Server"
],
"html": [
"A Minecraft Server"
]
},
"players": {
"online": 0,
"max": 20
},
"version": "1.21.130",
"online": true,
"protocol": {
"version": 898,
"name": "1.21.130"
},
"hostname": "xxxxxxxxxx.d.firewalla.org",
"map": {
"raw": "Powered by Nukkit",
"clean": "Powered by Nukkit",
"html": "Powered by Nukkit"
},
"gamemode": "Survival",
"serverid": "-35105637544509426xx"
}

So it looks like it is able to see my server. Under IP it shows my actual IP address, I just put x for security.

Thanks

[ItsMeBrille]

Ok, thanks for sharing.
I have not tested that much with bedrock version, but I can see what I can do to make it work.

But I will try to figure the difference between java and bedrock and maybe I will update it.

I'll copy your post for debugging to test with your setup, but if you worry about leaking your IP to others who might be lurking you should delete the comment above : )

[ItsMeBrille]

@rpbrown3622 I tested with your IP and I think the only change was a small fix that may occur when there are no players online. Can you pull the latest and test if it works now?

[rpbrown3622]

I installed the modules again and went online. but it still says undefined on my magicmirror. I even restarted the magic mirror itself. When I updated the module I just went into my modules folder and then installed git clone https://github.com/ItsMeBrille/MMM-MinecraftServer.git again. Is there something else to do to pull the latest.

[ItsMeBrille]

easiest way would just be to do:

cd MMM-MinecraftServer
git pull

but I believe what you did also should have worked. If you do git log you should be able to see that it has the commit I pushed 15 minutes ago.

Please update me if it still doesnt work

[rpbrown3622]

I ended up deleting the folder and reinstall and now I see it. I knew it was gonna say server offline. I was hoping to use that API that I gave you becasue It is able to see my server. I was wondering if that is something we could use.

Thanks

[ItsMeBrille]

I read it as it now works as you expected. However, if I'm missing something, please don't hesitate to reach back to me with more errors.

Please close the issue if not.

Also, I can see earlier versions of your comment above, so I would still recommend a deletion : )

[rpbrown3622]

Yes it now shows up. But like yiu siad, it showed up as offline. Could we use that api link to get it to see my server.

Thanks

[rpbrown3622]

So I change the api address in getplayers() section. It stopped saying server offline and changed to what the pic I uploaded. When I go one the server, it doesnt update to show what players are online.
I know Ive been keeping you busy on this but I sincerely appreciate all the effort.

Let me know what you think.

Module.register("MMM-MinecraftServer", {
defaults: {
ip: "192.168.0.194",
title: "Minecraft Server",
bedrock: true, // Whether the server is running on Bedrock edition
hidePlayers: false, // Hide player list
maxPlayers: 10, // Max players to show in list
hideInfo: false, // Hide bottom info (ip, version)
updateInterval: 5, // Default update interval (5 minutes)
},

players: [],
info: [],

start() {
Log.info(Starting module: ${this.name});
this.getPlayers();
setInterval(() => {
this.getPlayers();
}, this.config.updateInterval * 60000);
},

getStyles() {
return ["MMM-MinecraftServer.css"];
},

getPlayers() {
fetch(https://api.mcsrvstat.us/bedrock/3/xxxxxxxxxxx.d.firewalla.org)
.then((response) => response.json())
.then((data) => {
if (data.players && data.players.list) {
this.players = data.players.list;
}

    this.info.online = data.online;
    console.log(this.info.online);
    if (this.info.online) {
      this.info.motd = data.motd.html[0];
      this.info.hostname = data.hostname;
      this.info.port = data.port;
      this.info.version = data.version;
    }
    this.updateDom();
  })
  .catch((error) => {
    console.error("Error fetching Minecraft server data:", error);
  });

},

getDom() {
// Wrapper
const wrapper = document.createElement("div");
wrapper.className = "minecraft-card";

// Title
const title = document.createElement("h1");
title.className = "title";
title.innerHTML = this.config.title;
wrapper.appendChild(title);

// Server not available
if (!this.info.online) {
  const info = document.createElement("span");
  info.className = "motd";
  info.innerHTML = `Server offline`;
  wrapper.appendChild(info);
} else {
  // MOTD
  const motd = document.createElement("span");
  motd.className = "motd";
  motd.innerHTML = this.info.motd || "";
  wrapper.appendChild(motd);
}

// List players
if (!this.config.hidePlayers) {
  if (this.players.length > 0 && this.players[0].uuid === "00000000-0000-0000-0000-000000000000") {
    console.log("The server has turned off uuid visibility, showing default avatar");
  }
  const playerTable = document.createElement("table");
  playerTable.className = "players";

  this.players.slice(0, this.config.maxPlayers).forEach((player) => {
    const playerRow = document.createElement("tr");

    const avatarCell = document.createElement("td");
    const avatar = document.createElement("img");
    avatar.className = "player-avatar";
    avatar.src = `https://mc-heads.net/avatar/${player.uuid}/64`;
    avatarCell.appendChild(avatar);
    playerRow.appendChild(avatarCell);

    const nameCell = document.createElement("td");
    const playerName = document.createElement("span");
    playerName.className = "player-name";

    playerName.innerHTML = (player.name.length < 16) ? player.name : player.name.substring(0, 14) + "...";
    nameCell.appendChild(playerName);
    playerRow.appendChild(nameCell);

    const connectionCell = document.createElement("td");
    const connectionBars = document.createElement("div");
    connectionBars.className = "connection-bars";
    connectionCell.appendChild(connectionBars);
    playerRow.appendChild(connectionCell);

    playerTable.appendChild(playerRow);
  });
  wrapper.appendChild(playerTable);
}

// Info
if (!this.config.hideInfo) {
  const info = document.createElement("span");
  info.className = "info";
  info.innerHTML = `${this.config.ip}${this.config.bedrock ? "<br><i>Bedrock<i>" : ""}${this.info.version ? " - " + (this.info.version.length > 25 ? this.info.version.substring(0, 23) + '...' : `<i>${this.info.version}`) : ""}`;
  wrapper.appendChild(info);
}

return wrapper;

},
});