From 94c10f5f464f9a809a6676284d7491412a3539ca Mon Sep 17 00:00:00 2001
From: ghost <49853598+JSONbored@users.noreply.github.com>
Date: Sun, 12 Jul 2026 06:57:36 -0700
Subject: [PATCH] fix(review): index calibration login canonicalization

---
 ...ate_calibration_ledger_login_lower_idx.sql |  5 +++++
 .../predicted-gate-calibration-ledger.test.ts | 20 +++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 migrations/0147_predicted_gate_calibration_ledger_login_lower_idx.sql

diff --git a/migrations/0147_predicted_gate_calibration_ledger_login_lower_idx.sql b/migrations/0147_predicted_gate_calibration_ledger_login_lower_idx.sql
new file mode 100644
index 000000000..03694ce83
--- /dev/null
+++ b/migrations/0147_predicted_gate_calibration_ledger_login_lower_idx.sql
@@ -0,0 +1,5 @@
+-- Keep the contributor-triggered calibration read indexed after login casing canonicalization (#2349).
+-- SQLite/D1 cannot use the plain (login, created_at) index for WHERE lower(login) = ?, so this matching
+-- expression index preserves case-insensitive lookup semantics without scanning the insert-only ledger.
+CREATE INDEX IF NOT EXISTS predicted_gate_calibration_ledger_login_lower_idx
+  ON predicted_gate_calibration_ledger(lower(login), created_at);
diff --git a/test/unit/predicted-gate-calibration-ledger.test.ts b/test/unit/predicted-gate-calibration-ledger.test.ts
index f3814aed2..7bcaee589 100644
--- a/test/unit/predicted-gate-calibration-ledger.test.ts
+++ b/test/unit/predicted-gate-calibration-ledger.test.ts
@@ -234,6 +234,26 @@ describe("computeContributorCalibration — per-login calibration read (#2349)",
     expect(await computeContributorCalibration(env, "someone-else")).toEqual({ sampleSize: 1, agreementRate: 1 });
   });
 
+  it("uses the matching lower(login) expression index for canonicalized calibration lookups", async () => {
+    const env = createTestEnv();
+
+    const idx = await env.DB.prepare("SELECT name FROM sqlite_master WHERE type='index' AND name = ?")
+      .bind("predicted_gate_calibration_ledger_login_lower_idx")
+      .first<{ name: string }>();
+    expect(idx?.name).toBe("predicted_gate_calibration_ledger_login_lower_idx");
+
+    const plan = await env.DB.prepare(
+      `EXPLAIN QUERY PLAN SELECT COUNT(*) AS sampleSize, COALESCE(AVG(agreed), 0) AS agreementRate
+         FROM predicted_gate_calibration_ledger
+        WHERE lower(login) = ?`,
+    )
+      .bind("octocat")
+      .all<{ detail: string }>();
+    const detail = (plan.results ?? []).map((row) => row.detail).join(" ");
+    expect(detail).toContain("predicted_gate_calibration_ledger_login_lower_idx");
+    expect(detail).not.toContain("SCAN predicted_gate_calibration_ledger");
+  });
+
   it("aggregates across ALL of a login's history regardless of which repo each pairing came from", async () => {
     const env = createTestEnv();
     await seedLedgerRow(env, { login: "octocat", project: "owner/repo-a", pullNumber: 1, agreed: true });