From c83a808320e2bfdcbea96955d5f7c88399eb8ac6 Mon Sep 17 00:00:00 2001
From: davion-knight <298846663+davion-knight@users.noreply.github.com>
Date: Mon, 13 Jul 2026 04:55:02 -0500
Subject: [PATCH] feat(miner-extension): add a standard icon set to the
 manifest

The extension manifest defined no icons. Add a 16/32/48/128 PNG icon set (a dark 'G'
mark on the extension's mint accent, matching the opportunity badge) wired into both
manifest.icons and the toolbar action's default_icon, and include them in the build
package's file list so the packaged extension ships every icon it references.

Fixes #4862
---
 .../icons/icon-128.png                        | Bin 0 -> 1385 bytes
 .../icons/icon-16.png                         | Bin 0 -> 221 bytes
 .../icons/icon-32.png                         | Bin 0 -> 354 bytes
 .../icons/icon-48.png                         | Bin 0 -> 496 bytes
 apps/gittensory-miner-extension/manifest.json |  13 +++-
 scripts/build-miner-extension.mjs             |   8 ++-
 test/unit/miner-extension-icons.test.ts       |  56 ++++++++++++++++++
 7 files changed, 75 insertions(+), 2 deletions(-)
 create mode 100644 apps/gittensory-miner-extension/icons/icon-128.png
 create mode 100644 apps/gittensory-miner-extension/icons/icon-16.png
 create mode 100644 apps/gittensory-miner-extension/icons/icon-32.png
 create mode 100644 apps/gittensory-miner-extension/icons/icon-48.png
 create mode 100644 test/unit/miner-extension-icons.test.ts

diff --git a/apps/gittensory-miner-extension/icons/icon-128.png b/apps/gittensory-miner-extension/icons/icon-128.png
new file mode 100644
index 0000000000000000000000000000000000000000..acc7ab28e23dfd5fe5e12f28b0ddeae369bf8915
GIT binary patch
literal 1385
zcmV-v1(y1WP)<h;3K|Lk000e1NJLTq004jh004jp1^@s6!#-il000FrNkl<Zc-rlq
zzl#$=6vyXJh*)T+7IudO1Pg6qcOXcb>jaDIu1X<TxojymDQs*cmDpdskiS6E+oaqw
zf5OW5*p=LwJ9jtx<IT)x;K7m0&Q9L@zF#wMW}NGxC3!YY@@$dh*(%Aib&_Y>B+m+{
z5p7G}tx8@_o#mF~*}NR=4&n7iyOPIqD?*<nd6uH#qge>?elnKuQ?%WTRY->v{0xmZ
zYY}FB3x5ft&C{|kU%!UA-q5<U*q{{t2BvyPo1;Nc3ZFpF?*MUv=3@yaZ2*AJ4=5%e
z+J}}+@_ZN;Ce7*qfJvT!CyVM#@4~3CDJA72HJqURSOI)LvB33W4j2;`&G!MYf+5k-
zY99aue-Q?Q`vsgZBu<*Tvf>nG#7PVMf9!DptA3HM62_GOFMj<j&M&`S(b>18IQ?{S
zMf$t?T;GXmJ|NT|cd`Cny#4Z_cz*V#c>3x^aqs?vMx<x-tol%2q4Fsx0KEJ0xp;Yg
zRy=(Cq_M#NN9t33>m2~Vm|1_lc;AcA?*fC~8G^fTJ_}wNIh4?EBaOjlAUFgcHxRr6
zfFkxGO??~JpfLh~9wPcSk^ESsvHFrZm<NDzbjw<Qmo?DX0l*Pt(bu<$4FEtx`uO`Y
z2;uL8K)(q9)D*r?{=P|EU=aik;l~XEhtH2YCU6KpZV)&tsa`C?ugFS@=qya~_?YK+
zF;8G&vS@SwgdFtM2@0bIfacAIVDzJBCs%$~X7?_w)Bp4xeOJ#6F}AVS4&0cldVQOI
z2~uTVZO5o*`wmXUgE3bTU5HV?O1ZjZs`^r&A!Y?`EbZ@0n~u@=Iu@ZXt2LGtaG_}b
z$?0s6SvI{x?+V2VxDd2|4CZwS;;P^@3IM2>G8F%LEC{L!qA}M81_wZwK2)Z7>^!=S
zJ5Y)l<xHSz>bo?X7FO0YhPt2@So#c7%>$rIziEk)8jG(L!_G(ZubkW(BX7<VSn%(r
z0HA4B-*e_V*^MRtZVCX}WN9(#mtXFRB>b-W8VW>iEE8$P_gh^l9BPqhFaUJ1>?;lH
zdRzctAOKjM^Z@`KP5<`c7Xg5QJh?9QQ9=a(JOY4K*8~6ts`>>0o&un&+CKmQ0000k
z000mK0szuL0Kh~L0AMN@0I(PY09XzN02G8!5JE{9C1DhWQWQ#AIA!5%3}IskTf^8I
z#^z8qhq67K?cp2{!2uB*5yKHN91_JLQ5+M;F>xFe$w84E70Xev92U)C(Hs}gaq(Oj
z!G#fA8H4b-G>S{3xHgV!;|vxlaB*bh00=22;Of{8QbaC~ju-$5*T(~Z{j~$j)}X5J
z@rkEi0iaq%v=|#$uKW!O0M>xutKhu{z&;REXgZ{8(7W_bp9LQb0B-I(kVf_ahN^H=
z?+A%!K>^@q=AaF!D&=aELFgGht3G^*=-UEd8|sfc<Sta^B~p&Ah+U+=tItC)>kVit
z0IVbW!O(SD3jiw^5iP9*fCY?*mKFlQ6h=f#Q>T{X*$!qzM>|(F;($o~{~iG5FeEyf
zyZsi^d;pYf-OZNdSqfvKq4W>{CIo|V1b>pXJJhfOk!nA&K*YZP003q%Dp;DiIxWew
zCCmzrmaa)-l`ybXzoxCs3N|p$d)nL@_16ResbPpIAC>^kZwdlp0*`!tXTm2t2t3+v
z0fHHmMK&jSYUlYK0U;$oG!y8hZj4sO1}PR{G>uPt@%1giFfS{MunPTZ`|6)!4r{F}
rG+mT~U1K3yYxuh4;o@%rXUFXi#^RMR-nz1n00000NkvXXu0mjfkbi7=

literal 0
HcmV?d00001

diff --git a/apps/gittensory-miner-extension/icons/icon-16.png b/apps/gittensory-miner-extension/icons/icon-16.png
new file mode 100644
index 0000000000000000000000000000000000000000..ef4576ea84bc877a57a12240a76f9b4dd1fc593c
GIT binary patch
literal 221
zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`OFUg1Ln>}1Cjh~U>V4`9-u;~S
zyY&3`Kk7owSJ(^`GXMFj@g*o+OyikukT6-pV)vi@$&P>OW%=0+*fu&Q-MEq@Az-!m
z-Ts!QNA-@0g(5sc%qJh3GNf?(Y+kkXX8rzkLO^wiZ3}j@9A%ggoH*-rer{8D^NnK*
z?<E|baMX~8;iq^CgNLFI&s}W=(=EmgN%{dY9U|_^J2^WaE%Av=TV!I*%rK*Od4I@5
SSv8=089ZJ6T-G@yGywp36H`+F

literal 0
HcmV?d00001

diff --git a/apps/gittensory-miner-extension/icons/icon-32.png b/apps/gittensory-miner-extension/icons/icon-32.png
new file mode 100644
index 0000000000000000000000000000000000000000..cb37b26ae21fbbb42ef881f333fa1373338618fe
GIT binary patch
literal 354
zcmV-o0iFJdP)<h;3K|Lk000e1NJLTq001BW001Be1^@s6b9#F80003gNkl<Zc-muN
zKmv8o_XyNI-_ua{e9!s1=X?HB8J~xmEx>>c)IHymQ1^V#dm31bjzM-LV6*%`opAzk
zu)iMw2fPPI2Q*&(4-jr(pizP&I$<)9qcM5Y<o_PEStuAJMvhq|IRIplgo5IKL1A&M
z7$gT$Lv;sa?VtN!)!GcF#poEM7NmzN4geX1&)4`ugBV8;bO0`&gDlYTZ~$Xm4g~3?
z$N`}E#Ab2mj5-XpATewXA(STYIsn~3Lcxk2T~^7V1fzigUsgl+4K|;H)FETXf_QMy
zgVe&r3eGMk-2v#q5Aqo{b;Kk{e9=I(13-ywWIKTFQ83_%aKN+SpeTq2yeJ+NmC=A#
z$Ah9lLhB~kfHz79yjec59g_j?nhlE1=|FbR0p(+bsiON7Jpcdz07*qoM6N<$f<thU
Ag8%>k

literal 0
HcmV?d00001

diff --git a/apps/gittensory-miner-extension/icons/icon-48.png b/apps/gittensory-miner-extension/icons/icon-48.png
new file mode 100644
index 0000000000000000000000000000000000000000..ccaf2d2beaed2198981e913f1e14989942136b9f
GIT binary patch
literal 496
zcmV<M0T2F(P)<h;3K|Lk000e1NJLTq001xm001xu1^@s6R|5Hm0005ENkl<Zc-rk+
zyGjHx6wNP)g?5gG-68{mg*KK8f=n}=-F9192v(++ZMLwnu@w8Q1M>y`fIpCOJ|S{s
zgSu=U^Kx=8J8)px$t368+<WsB!tqG0a;eo)YE?<C%t)x#9C8u+NUgGwN&CcPA@YUP
zs!ou+1-KPH@`ebCZEjN&5>Wqfr$l`|7!$v<jUkF$tkV=#0ZXdx^W#QCR6MU<&205-
zZWj07z;FCFL|eTHxP5yvXXUjy%#O|8{=rt@9m=3=G6G=Tqtl6#v<vtK-;O5W;d5m!
zW@TgIn?N0?>t6++!IR7L&g3mnS6dNcZ1P=2G#1c@+xXmRPyq<KnBcUj6BY$*N{tEj
zrh(l^K#0KfaUQG#WkLoRL;!NPui^4VMmLJGF7kNSBo?9tU;yf3d0$UVrdO>8w`c*b
z5jNE2@M#y2d2GCF;_l<UKLMD>xU3HXzHi%Rq}W~+U9(RpYa}56R(3TM3b>tsoeOaY
zV)AK}#Xv@WDnWiS$6`87enG=xNlAWD&thAJ#l{w!t;G~Jcgb(BlRw~~eZ)lmkdMVN
mEBS+N7FP{eT=t-N-R28xV3Yh~vHs!!0000<MNUMnLSTYuxZuwK

literal 0
HcmV?d00001

diff --git a/apps/gittensory-miner-extension/manifest.json b/apps/gittensory-miner-extension/manifest.json
index f27558bd7..a43eb2d15 100644
--- a/apps/gittensory-miner-extension/manifest.json
+++ b/apps/gittensory-miner-extension/manifest.json
@@ -3,6 +3,12 @@
   "name": "LoopOver Miner Opportunity",
   "description": "Contributor-facing GitHub issue opportunity signals from a locally configured miner plane.",
   "version": "0.1.0",
+  "icons": {
+    "16": "icons/icon-16.png",
+    "32": "icons/icon-32.png",
+    "48": "icons/icon-48.png",
+    "128": "icons/icon-128.png"
+  },
   "permissions": ["storage"],
   "host_permissions": ["https://github.com/*", "http://localhost/*", "http://127.0.0.1/*"],
   "background": {
@@ -19,6 +25,11 @@
   ],
   "options_page": "options.html",
   "action": {
-    "default_title": "LoopOver Miner"
+    "default_title": "LoopOver Miner",
+    "default_icon": {
+      "16": "icons/icon-16.png",
+      "32": "icons/icon-32.png",
+      "48": "icons/icon-48.png"
+    }
   }
 }
diff --git a/scripts/build-miner-extension.mjs b/scripts/build-miner-extension.mjs
index 67d4a4fd4..d22e73a73 100644
--- a/scripts/build-miner-extension.mjs
+++ b/scripts/build-miner-extension.mjs
@@ -22,13 +22,19 @@ const PACKAGE_FILES = [
   "options.js",
   "styles.css",
   "toolbar-badge.js",
+  "icons/icon-16.png",
+  "icons/icon-32.png",
+  "icons/icon-48.png",
+  "icons/icon-128.png",
 ];
 
 rmSync(outDir, { recursive: true, force: true });
 mkdirSync(outDir, { recursive: true });
 
 for (const file of PACKAGE_FILES) {
-  cpSync(resolve(source, file), resolve(outDir, file));
+  const dest = resolve(outDir, file);
+  mkdirSync(dirname(dest), { recursive: true }); // create nested dirs (e.g. icons/) before copying
+  cpSync(resolve(source, file), dest);
 }
 
 const zipPath = resolve(source, "dist/loopover-miner-extension.zip");
diff --git a/test/unit/miner-extension-icons.test.ts b/test/unit/miner-extension-icons.test.ts
new file mode 100644
index 000000000..d9230bc07
--- /dev/null
+++ b/test/unit/miner-extension-icons.test.ts
@@ -0,0 +1,56 @@
+import { existsSync, readFileSync } from "node:fs";
+
+import { describe, expect, it } from "vitest";
+
+const EXT = "apps/gittensory-miner-extension";
+const manifest = JSON.parse(readFileSync(`${EXT}/manifest.json`, "utf8"));
+
+/** Parse a PNG's signature + IHDR (width/height/colorType) — enough to assert a real image of the expected size. */
+function readPng(path: string): {
+  valid: boolean;
+  width: number;
+  height: number;
+  colorType: number;
+} {
+  const buf = readFileSync(path);
+  const valid =
+    buf.subarray(0, 8).toString("hex") === "89504e470d0a1a0a" &&
+    buf.subarray(12, 16).toString("ascii") === "IHDR";
+  return {
+    valid,
+    width: buf.readUInt32BE(16),
+    height: buf.readUInt32BE(20),
+    colorType: buf[25] ?? 0,
+  };
+}
+
+describe("miner extension icons (#4862)", () => {
+  const SIZES = [16, 32, 48, 128] as const;
+
+  it("declares an icon set at the standard sizes in the manifest", () => {
+    for (const size of SIZES) {
+      expect(manifest.icons[String(size)]).toBe(`icons/icon-${size}.png`);
+    }
+  });
+
+  it("wires the toolbar action's default_icon at 16/32/48", () => {
+    for (const size of [16, 32, 48] as const) {
+      expect(manifest.action.default_icon[String(size)]).toBe(
+        `icons/icon-${size}.png`,
+      );
+    }
+  });
+
+  it("ships every declared icon as a real RGBA PNG whose dimensions match its declared size", () => {
+    for (const size of SIZES) {
+      const rel = manifest.icons[String(size)] as string;
+      const path = `${EXT}/${rel}`;
+      expect(existsSync(path), `${rel} exists`).toBe(true);
+      const png = readPng(path);
+      expect(png.valid, `${rel} is a valid PNG`).toBe(true);
+      expect(png.width).toBe(size);
+      expect(png.height).toBe(size);
+      expect(png.colorType).toBe(6); // 6 = truecolor + alpha (RGBA)
+    }
+  });
+});