chore: bump rhiza to v0.18.8#788
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Rhiza template lock to v0.18.8 and adjusts the synced CI/release/testing infrastructure accordingly (including new release safeguards and Makefile API tests).
Changes:
- Bump Rhiza template reference/lock to v0.18.8 and sync downstream template artifacts.
- Update release workflow with a tag version “newer than latest” guard and add optional conda recipe generation via
grayskull. - Replace SBOM integration testing with API-level Makefile tests (variable overrides / GitHub targets) and add a
mutationmake target backed bymutmut.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml.template |
Removes legacy template content (now effectively deprecated by the Rhiza sync). |
.rhiza/tests/structure/test_pyproject.py |
Adds a structure test requiring pyproject.toml version to match the latest git tag. |
.rhiza/tests/integration/test_sbom.py |
Removes SBOM generation integration tests. |
.rhiza/tests/api/test_makefile_targets.py |
Updates bump-tool version assertions to match new Rhiza tooling. |
.rhiza/tests/api/test_make_variable_overrides.py |
Adds tests verifying Makefile variable override behavior in dry-runs. |
.rhiza/tests/api/test_github_targets.py |
Adds dry-run tests for GitHub-related Makefile targets (currently gated on github.mk). |
.rhiza/template.yml |
Updates Rhiza template ref to v0.18.8. |
.rhiza/template.lock |
Updates template lock SHA/ref and synced file list for v0.18.8. |
.rhiza/requirements/tests.txt |
Adds mutmut to test requirements for mutation testing. |
.rhiza/make.d/test.mk |
Adds a mutation target to run mutation testing via mutmut. |
.rhiza/make.d/releasing.mk |
Updates rhiza-tools minimum version used for release/bump targets. |
.github/workflows/rhiza_weekly.yml |
Updates reusable workflow reference for weekly Rhiza workflow. |
.github/workflows/rhiza_sync.yml |
Updates reusable workflow reference for Rhiza sync workflow. |
.github/workflows/rhiza_release.yml |
Adds release version guard, optional conda recipe job, and updates finalization logic. |
.github/workflows/rhiza_marimo.yml |
Updates reusable workflow reference for marimo workflow. |
.github/workflows/rhiza_codeql.yml |
Updates reusable workflow reference for CodeQL workflow. |
.github/workflows/rhiza_ci.yml |
Updates reusable workflow reference for CI workflow. |
.github/workflows/rhiza_book.yml |
Updates reusable workflow reference for book workflow. |
.github/workflows/rhiza_benchmark.yml |
Updates reusable workflow reference for benchmark workflow. |
.github/actions/configure-git-auth/README.md |
Removes local composite action documentation. |
.github/actions/configure-git-auth/action.yml |
Removes local composite action implementation. |
Comments suppressed due to low confidence (1)
.github/workflows/rhiza_sync.yml:35
uses:reference was changed from v0.18.5 to v0.18.4, which appears to be a downgrade and is inconsistent with the PR's Rhiza v0.18.8 bump. This can cause the sync behavior to diverge from the template lock/version you are updating.
jobs:
sync:
uses: jebel-quant/rhiza/.github/workflows/rhiza_sync.yml@v0.18.4
with:
direct: ${{ github.event_name == 'push' }}
create-pr: ${{ github.event_name != 'push' && (github.event_name == 'schedule' || inputs.create-pr == true) }}
secrets: inherit
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
26
to
29
| jobs: | ||
| weekly: | ||
| uses: jebel-quant/rhiza/.github/workflows/rhiza_weekly.yml@v0.18.5 | ||
| uses: jebel-quant/rhiza/.github/workflows/rhiza_weekly.yml@v0.18.4 | ||
| secrets: inherit |
Comment on lines
+199
to
+208
| result = subprocess.run( # nosec B603 | ||
| [_GIT, "tag", "--list", "v*", "--sort=-version:refname"], | ||
| capture_output=True, | ||
| text=True, | ||
| cwd=root, | ||
| ) | ||
| tags = [line.strip() for line in result.stdout.splitlines() if line.strip()] | ||
| if not tags: | ||
| pytest.skip("No version tags found in repository") | ||
| return tags[0] |
Comment on lines
+141
to
+146
| def test_uv_no_modify_path_cannot_be_overridden_to_empty(self, logger) -> None: | ||
| """UV_NO_MODIFY_PATH must still appear in the printed value when queried.""" | ||
| proc = run_make(logger, ["print-UV_NO_MODIFY_PATH"], dry_run=False) | ||
| out = strip_ansi(proc.stdout) | ||
| assert "UV_NO_MODIFY_PATH" in out | ||
|
|
Comment on lines
+157
to
+161
| def test_pytest_uses_tests_folder(self, logger) -> None: | ||
| """The test target must invoke pytest with the TESTS_FOLDER path.""" | ||
| proc = run_make(logger, ["test"]) | ||
| # The default tests folder must appear somewhere in the pytest invocation | ||
| assert "pytest" in proc.stdout |
Comment on lines
+567
to
+568
| needs: [tag, pypi, conda, devcontainer] | ||
| if: needs.pypi.result == 'success' || needs.conda.result == 'success' || needs.devcontainer.result == 'success' |
Comment on lines
+16
to
+19
| _GITHUB_MK = Path(__file__).resolve().parents[3] / ".rhiza" / "make.d" / "github.mk" | ||
| if not _GITHUB_MK.exists(): | ||
| pytest.skip("github.mk not found, skipping github targets tests", allow_module_level=True) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configure-git-authcomposite action (inlined into release workflow)grayskullTest plan
test_github_targets.py,test_make_variable_overrides.py) pass🤖 Generated with Claude Code