fix: add LinkDef.h for janaview and data model example plugins#498
Merged
Conversation
In ROOT v6.40.00, a LinkDef.h is required (or a C++ module) [1], and this commit adds a minimal LinkDef.h for the janaview and ROOT data model example plugins where it was missing. [1] root-project/root@d3b89850ce6
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds explicit ROOT LinkDef files and wires them into CMake dictionary generation so ROOT can generate reflection dictionaries for janaview and the RootDatamodelExample classes.
Changes:
- Added
*_LinkDef.hfiles forjv_mainframe,Hit, andCluster. - Updated
ROOT_GENERATE_DICTIONARY(...)calls to includeLINKDEF ....
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/janaview/jv_mainframe_LinkDef.h | Adds ROOT pragma link directives for jv_mainframe dictionary generation. |
| src/plugins/janaview/CMakeLists.txt | Passes LINKDEF to ROOT_GENERATE_DICTIONARY for janaview. |
| src/examples/misc/RootDatamodelExample/Hit_LinkDef.h | Adds ROOT pragma link directives for Hit dictionary generation. |
| src/examples/misc/RootDatamodelExample/Cluster_LinkDef.h | Adds ROOT pragma link directives for Cluster dictionary generation. |
| src/examples/misc/RootDatamodelExample/CMakeLists.txt | Passes LINKDEF to ROOT_GENERATE_DICTIONARY for example classes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
FYI @nathanwbrei |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ROOT v6.40.00, a LinkDef.h is required (or a C++ module), and this commit adds a minimal LinkDef.h for the janaview and ROOT data model example plugins where it was missing.