Skip to content

Refreshing project#92

Open
philips77 wants to merge 41 commits into
masterfrom
migration/arctic-fox
Open

Refreshing project#92
philips77 wants to merge 41 commits into
masterfrom
migration/arctic-fox

Conversation

@philips77

@philips77 philips77 commented Aug 25, 2021

Copy link
Copy Markdown
Collaborator

This PR introduces the following changes to the library and sample project:

  • Migration to Android Studio Arctic Fox - Patch 1
  • Migration to Kotlin 1.5.30
  • Migration to Java 1.8 (lambdas)
  • Migration to Android BLE Library 2.3.0
  • Fixing all deprecations
    • onActivityCreated -> onViewCreated
    • onActivityResult -> registerForActivityResult
  • Migration from ButterKnife to View Bindings 8f9e5fe
  • Bug fix: McuMgrBleTransport should return errors as error 2e712de, not a response

@philips77 philips77 requested a review from bgiori August 25, 2021 17:21
@philips77 philips77 self-assigned this Aug 25, 2021
@philips77 philips77 marked this pull request as ready for review August 26, 2021 11:46
@philips77 philips77 mentioned this pull request Aug 26, 2021
@philips77

Copy link
Copy Markdown
Collaborator Author

Btw, the gradle publishing script needs to be updated, or the project won't compile. Locally I uncommeted last lines in build.gradle files for both lib modules.

@twyatt

twyatt commented Aug 27, 2021

Copy link
Copy Markdown
Contributor

@philips77 I've requested internally that the review requirements be lifted on this repo, or that you be given access to configure the repo as needed. So that you can merge PRs as needed.

@philips77 philips77 removed the request for review from bgiori August 27, 2021 08:50
@saadalowerdi

Copy link
Copy Markdown

This PR introduces the following changes to the library and sample project:

  • Migration to Android Studio Arctic Fox - Patch 1

  • Migration to Kotlin 1.5.30

  • Migration to Java 1.8 (lambdas)

  • Migration to Android BLE Library 2.3.0

  • Fixing all deprecations

    • onActivityCreated -> onViewCreated
    • onActivityResult -> registerForActivityResult
  • Migration from ButterKnife to View Bindings 8f9e5fe

  • Bug fix: McuMgrBleTransport should return errors as error 2e712de, not a response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants