Skip to content

Remove vendored CMake Module: FindVulkan.cmake #1489

@fgiancane8

Description

@fgiancane8

Hello all! I recently posted a patch to cmake which after some discussions, got merged recently. You can see the link here.

There were couple of issues for Windows platforms preventing CMake to properly detect ARM64/x86_64 versions of libraries in Cross-Compilation scenarios, which got amended now.

Since we have here an override for the same module, unless we ported these changes, this would prevent Vulkan-Samples to properly build on Windows on ARM64 from Intel devices and vice-versa.

I propose to remove the downstream version from this repository, and let people rely solely on the CMake provided module to discover/find Vulkan.

Impact for users:

  • People already relying on vendored FindVulkan.cmake module, upon branch update, will get to use the CMake bundled version. No impact on them as the upstream CMake module is newer than the one bundled here and maintained more often. Still, the samples cannot be cross-compiled on Windows, with LunarG SDK.
  • People that will also update CMake to latest release (patch is supposed to be GA in 4.3.0) will get the same benefits AND the ability to cross-compile as well.

Any thoughts on this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions